Adding a new API that allows iOS users to log notification delivery signal that exports to BigQuery. #6181

charlotteliang · 2020-07-31T19:01:30Z

We got approved within our team to proceed with this launch. Please review this again, the API review is approved at
go/fm-ios-delivery

;

maksymmalyhin · 2020-07-31T19:41:32Z

@chliangGoogle I feel like there must be a LaunchCall associated with the feature. I think it would be useful to link it to the PR somehow.

charlotteliang · 2020-07-31T19:44:44Z

I'm still struggling with the nanopb encoding, once the code is ready for review, I will kick off a launchcal.

paulb777 · 2020-10-09T22:49:24Z

@chliangGoogle Is this PR still relevant? If not please close.

charlotteliang · 2020-10-12T16:53:24Z

@paulb777 It is blocked on internal PM review.

…-firelog

google-oss-bot · 2021-06-02T23:32:25Z

Coverage Report

Affected SDKs

`FirebaseMessaging-iOS-FirebaseMessaging.framework`

SDK overall coverage changed from 64.35% (04ab074) to 64.60% (d45e2fe) by +0.25%.

Filename	Base (`04ab074`)	Head (`d45e2fe`)	Diff
FIRMessagingContextManagerService.m	66.83%	66.99%	+0.16%
FIRMessagingExtensionHelper.m	82.68%	85.91%	+3.23%
FIRMessagingTokenManager.m	42.92%	42.15%	-0.77%

Test Logs

Base (04ab0742): https://github.com/firebase/firebase-ios-sdk/actions/runs/1050441378
Head (d45e2fe9): https://github.com/firebase/firebase-ios-sdk/actions/runs/1054403166

paulb777

This needs a rebase to the latest master and tests passing.

FirebaseMessaging.podspec

…d sample app already covers it

maksymmalyhin

LGTM, with a couple minor comments/questions.

FirebaseMessaging/ProtoSupport/proto_generator.py

FirebaseMessaging/Sources/FIRMessagingConstants.m

FirebaseMessaging/Sources/FIRMessagingExtensionHelper.m

FirebaseMessaging.podspec

FirebaseMessaging/ProtoSupport/generate_protos.sh

FirebaseMessaging.podspec

FirebaseMessaging/ProtoSupport/Protos/me.options

FirebaseMessaging/Sources/Protogen/nanopb/me.nanopb.c

FirebaseMessaging/Sources/FIRMessagingExtensionHelper.m

FirebaseMessaging/ProtoSupport/Protos/me.proto

FirebaseMessaging/Sources/Protogen/nanopb/me.nanopb.h

FirebaseMessaging.podspec

…elivery signal that exports to BigQuery. (#6181)" This reverts commit ce87d25.

…livery signal that exports to BigQuery." (#8458) * Revert "Prevent firelog from logging invalid data (#8443)" This reverts commit 7fc7325. * Revert "Update changelog (#8440)" This reverts commit ecc7d6d. * Revert " Adding a new API that allows iOS users to log notification delivery signal that exports to BigQuery. (#6181)" This reverts commit ce87d25.

charlotteliang added 6 commits July 22, 2020 16:16

add nanopb files for messaging

6210292

fix nanopb data encode/decode

f8a096a

add extension to test app

10fde21

update proto files

806e046

;

add a gdt proto for comparison

e5f744b

proto3 to proto2

a715889

googlebot added the cla: yes label Jul 31, 2020

resolve conflicts

a183392

google-oss-bot added api: messaging public-api-change labels Jul 31, 2020

charlotteliang added 10 commits July 31, 2020 12:54

add test code for easy calling the problem function

1d33294

use the same proto as gdt as a debug example

58bd024

add nanopb files

8b3ca97

fix typo in podspec

e9e12f0

figure out issue on encoding revert back logging logic

021d957

adding data message testing on test app

a77c872

define constant string for easy management;

7a72d75

add unit test

a944ce3

merge conflict

a35ca7d

update the nanopb version

ebc9ea1

charlotteliang added 6 commits October 13, 2020 16:51

fix breakage

d8fdaba

remove trailing whitespace

53f4c25

fix copywrite

0dcafb0

Merge branch 'master' of github.com:firebase/firebase-ios-sdk into fm…

637bd0a

…-firelog

update google data transporter header

8328bb3

update proto header

ea0e001

fix test header

f4b5d9d

charlotteliang changed the title ~~[draft] Using Firelog to log delivery metrics for Messaging~~ Adding a new API that allows iOS users to log notification delivery signal that exports to BigQuery. Jun 2, 2021

clang format

f742507

paulb777 reviewed Jun 3, 2021

View reviewed changes

FirebaseMessaging.podspec Outdated Show resolved Hide resolved

charlotteliang added 3 commits June 3, 2021 12:54

add missing dependency in SPM to fix breakage

2e073ff

remove service extension target from regular sample app since advance…

de88f99

…d sample app already covers it

fix a breakage in watchos test

55ebe19

maksymmalyhin approved these changes Jun 7, 2021

View reviewed changes

ncooke3 reviewed Jun 7, 2021

View reviewed changes

FirebaseMessaging.podspec Outdated Show resolved Hide resolved

paulb777 reviewed Jun 7, 2021

View reviewed changes

FirebaseMessaging.podspec Outdated Show resolved Hide resolved

FirebaseMessaging.podspec Outdated Show resolved Hide resolved

FirebaseMessaging/ProtoSupport/generate_protos.sh Outdated Show resolved Hide resolved

charlotteliang added 4 commits July 13, 2021 14:45

merge with master

fe7da0c

fm-firelog

f656526

merge conflicts

10753dd

merge conflict

641dd67

paulb777 reviewed Jul 21, 2021

View reviewed changes

charlotteliang added 3 commits July 21, 2021 16:17

update version number

8660466

remove unused header

adec968

fix tvOS breakage

9b022b2

github-actions bot reviewed Jul 22, 2021

View reviewed changes

FirebaseMessaging/Sources/FIRMessagingExtensionHelper.m Show resolved Hide resolved

github-actions bot reviewed Jul 22, 2021

View reviewed changes

FirebaseMessaging/Sources/FIRMessagingExtensionHelper.m Show resolved Hide resolved

github-actions bot reviewed Jul 22, 2021

View reviewed changes

FirebaseMessaging/Sources/FIRMessagingExtensionHelper.m Show resolved Hide resolved

github-actions bot reviewed Jul 22, 2021

View reviewed changes

FirebaseMessaging/Sources/FIRMessagingExtensionHelper.m Show resolved Hide resolved

paulb777 reviewed Jul 22, 2021

View reviewed changes

FirebaseMessaging/ProtoSupport/Protos/me.proto Show resolved Hide resolved

FirebaseMessaging/Sources/Protogen/nanopb/me.nanopb.h Show resolved Hide resolved

FirebaseMessaging.podspec Show resolved Hide resolved

charlotteliang merged commit ce87d25 into master Jul 27, 2021

charlotteliang deleted the fm-firelog branch July 27, 2021 18:16

maksymmalyhin added a commit that referenced this pull request Jul 29, 2021

Revert " Adding a new API that allows iOS users to log notification d…

dffc37a

…elivery signal that exports to BigQuery. (#6181)" This reverts commit ce87d25.

maksymmalyhin mentioned this pull request Jul 29, 2021

Revert "Adding a new API that allows iOS users to log notification delivery signal that exports to BigQuery." #8458

Merged

firebase locked and limited conversation to collaborators Aug 27, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding a new API that allows iOS users to log notification delivery signal that exports to BigQuery. #6181

Adding a new API that allows iOS users to log notification delivery signal that exports to BigQuery. #6181

charlotteliang commented Jul 31, 2020 •

edited

Loading

maksymmalyhin commented Jul 31, 2020

charlotteliang commented Jul 31, 2020

paulb777 commented Oct 9, 2020

charlotteliang commented Oct 12, 2020 •

edited

Loading

google-oss-bot commented Jun 2, 2021 •

edited

Loading

`FirebaseMessaging-iOS-FirebaseMessaging.framework`

paulb777 left a comment

maksymmalyhin left a comment

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Adding a new API that allows iOS users to log notification delivery signal that exports to BigQuery. #6181

Adding a new API that allows iOS users to log notification delivery signal that exports to BigQuery. #6181

Conversation

charlotteliang commented Jul 31, 2020 • edited Loading

maksymmalyhin commented Jul 31, 2020

charlotteliang commented Jul 31, 2020

paulb777 commented Oct 9, 2020

charlotteliang commented Oct 12, 2020 • edited Loading

google-oss-bot commented Jun 2, 2021 • edited Loading

Coverage Report

Affected SDKs

FirebaseMessaging-iOS-FirebaseMessaging.framework

Test Logs

paulb777 left a comment

Choose a reason for hiding this comment

maksymmalyhin left a comment

Choose a reason for hiding this comment

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

charlotteliang commented Jul 31, 2020 •

edited

Loading

charlotteliang commented Oct 12, 2020 •

edited

Loading

google-oss-bot commented Jun 2, 2021 •

edited

Loading

`FirebaseMessaging-iOS-FirebaseMessaging.framework`