Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up usage of deprecated methods in unit tests #6618

Merged
merged 3 commits into from
Sep 30, 2020
Merged

Clean up usage of deprecated methods in unit tests #6618

merged 3 commits into from
Sep 30, 2020

Conversation

karenyz
Copy link
Contributor

@karenyz karenyz commented Sep 30, 2020 •
edited
Loading

Separating this from the actual API removal PR for #6546

  • Remove tests for deprecated methods
  • Update other tests to no longer call deprecated methods

@google-cla google-cla bot added the cla: yes label Sep 30, 2020
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@karenyz karenyz linked an issue Sep 30, 2020 that may be closed by this pull request
Remote Config: Remove deprecated APIs #6546
Closed
@karenyz karenyz added this to the Firebase 7 milestone Sep 30, 2020
@karenyz karenyz removed a link to an issue Sep 30, 2020
Remote Config: Remove deprecated APIs #6546
Closed
charlotteliang
charlotteliang approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@charlotteliang charlotteliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@karenyz karenyz merged commit fa9c24a into master Sep 30, 2020
@karenyz karenyz deleted the kz-rc-unittest branch September 30, 2020 22:38
@firebase firebase locked and limited conversation to collaborators Oct 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@charlotteliang charlotteliang charlotteliang approved these changes

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: remoteconfig cla: yes
Projects
None yet
Milestone
Firebase 7 - M82
Development

Successfully merging this pull request may close these issues.
4 participants
@karenyz @google-oss-bot @paulb777 @charlotteliang
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy