-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multi-factor authentication with email link sign in #8705
Support multi-factor authentication with email link sign in #8705
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Thanks for the contribution @0x0c, I'll trigger the workflows. This change may need to go through API review, so it will likely take some time to approve. |
@morganchen12 Thank you for your reply. I want to use email link sign in feature with MFA for our product. Could you tell me how long will API review take? I fixed codes for job failure, so please run workflow again 🙇 |
@0x0c API review will likely take between two weeks and a month for a relatively small feature (by my estimate, not a guaranteed time frame). If you want to use your change immediately, you can install Firebase from your branch of this repository. Instructions for CocoaPods | Instructions for Swift Package Manager |
@morganchen12 I got it. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution! Good news -- I checked with the team, and since this doesn't change the public API surface, it doesn't need to go through API review.
This overall LGTM, but adding in @renkelvin since he has more familiarity with the MFA flows.
@rosalyntan I added documentation 49cc42f. Please check my commit and let me know if any concerns you have :) |
Thank you! |
Congratulations to everyone involved in this change! I'm amazed at the speed from issue to pr to acceptance to merging and being ready for the next release! ❤️ |
Discussion
Motivation of this pull request is to support MFA with email link sign in. Unfortunately, firebase-ios-sdk does not support email link sign in with MFA even if the document mentioned as supported (https://cloud.google.com/identity-platform/docs/ios/mfa). This issue is already reported in #7770
I found a reason of this issue and fix it as follows:
mfaInfo
inFIREmailLinkSignInResponse
.FIRVerifyPasswordResponse
.Testing
All tests are passed (
FirebaseAuth-Unit-unit
). I tested email link sign in feature and MFA with my sample project and I confirmed it works. I uploaded MCVE. See this repo.API Changes
There are no api changes.
Please let me know if I have mistake :)