Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting GarbageSource in SyncEngine's constructor #1010

Merged
merged 2 commits into from
Jul 16, 2018
Merged

Setting GarbageSource in SyncEngine's constructor #1010

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b55172
Setting GarbageSource in SyncEngine's constructor
schmidt-sebastian Jul 16, 2018
02fd524
Merge branch 'master' into mrschmidt-fixallthethings
schmidt-sebastian Jul 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/firestore/src/core/sync_engine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,9 @@ export class SyncEngine implements RemoteSyncer {
private localStore: LocalStore,
private remoteStore: RemoteStore,
private currentUser: User
) {}
) {
this.limboCollector.addGarbageSource(this.limboDocumentRefs);
}

/** Subscribes view and error handler. Can be called only once. */
subscribe(viewHandler: ViewHandler, errorHandler: ErrorHandler): void {
Expand All @@ -144,7 +146,6 @@ export class SyncEngine implements RemoteSyncer {
);
this.viewHandler = viewHandler;
this.errorHandler = errorHandler;
this.limboCollector.addGarbageSource(this.limboDocumentRefs);
}

/**
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy