-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💡 setup:emulators:ui #3152
Merged
Merged
💡 setup:emulators:ui #3152
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mac2000 thank you! This LGTM |
samtstern
approved these changes
Feb 22, 2021
samtstern
added a commit
that referenced
this pull request
Feb 22, 2021
joehan
added a commit
that referenced
this pull request
Feb 22, 2021
This was referenced Mar 9, 2021
Closed
Closed
Closed
This was referenced Mar 12, 2021
devpeerapong
pushed a commit
to devpeerapong/firebase-tools
that referenced
this pull request
Dec 14, 2021
devpeerapong
pushed a commit
to devpeerapong/firebase-tools
that referenced
this pull request
Dec 14, 2021
Co-authored-by: joehan <joehanley@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3151
Motivation: to build docker image with firestore emulator and ui we can prefetch firestore emulator with help of
setup:emulators:firestore
but there is no such command for ui, so it is being downloaded each time container starts.Workaround: meanwhile workaround is to
What was done:
If I understood everything correctly all we need is add
src/commands/setup-emulators-ui.js
And add it to
src/commands/index.js