Skip to content

Request 3181 #3194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Request 3181 #3194

wants to merge 2 commits into from

Conversation

stopsopa
Copy link

@stopsopa stopsopa commented Jan 9, 2025 •
edited
Loading

PR implementing suggested exports: #3181 (comment)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: f2160ed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify Netlify
Copy link

netlify bot commented Jan 9, 2025 •
edited
Loading

✅ Deploy Preview for vibrant-gates-22c214 ready!

Name Link
🔨 Latest commit f2160ed
🔍 Latest deploy log https://app.netlify.com/sites/vibrant-gates-22c214/deploys/67818d6b8dab5100082f765b
😎 Deploy Preview https://deploy-preview-3194--vibrant-gates-22c214.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stopsopa stopsopa force-pushed the request-3181 branch 2 times, most recently from efd7c90 to 280d1e6 Compare January 9, 2025 15:01
FezVrasta
FezVrasta reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@FezVrasta FezVrasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we should also document on the website that these exports don't follow semver and may break on fix releases too.

@stopsopa
Copy link
Author

stopsopa commented Jan 10, 2025 •
edited
Loading

@FezVrasta - To be honest looking into documentation I'm not really sure where to mention it, probably wherever I would try to add it it would be just noise.
Probably it would be better to keep doc as is to keep it concise and focused on the task.

Or maybe you would have any suggestion where to put it?

Initially I've rather intended to just export it and not document it, this way it is out of the box non official api which can be found only by reading the code.

I could though comment it above those exports in the code...

...I did that in this PR.

Let me know if that will do...

@stopsopa
Copy link
Author

So any suggestions where to document that? @FezVrasta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FezVrasta FezVrasta FezVrasta left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stopsopa @FezVrasta
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy