Skip to content

Remove JIT release x86 mode #151610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jtmcdole opened this issue Jul 11, 2024 · 9 comments · Fixed by flutter/engine#56548
Closed

Remove JIT release x86 mode #151610

jtmcdole opened this issue Jul 11, 2024 · 9 comments · Fixed by flutter/engine#56548
Assignees
@matanlurey
Labels
engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team

Comments

@jtmcdole
Copy link
Member

No description provided.

@jtmcdole jtmcdole added engine flutter/engine repository. See also e: labels. team-engine Owned by Engine team labels Jul 11, 2024
@jiahaog
Copy link
Member

jiahaog commented Jul 12, 2024

While internally we have stopped depending on android_x86_jit_release prebuilts this week, we should put this issue on hold for a month or so in case we need to roll back.

@jtmcdole jtmcdole added the P3 Issues that are less important to the Flutter project label Jul 12, 2024
@jtmcdole
Copy link
Member Author

What's a good label for backlog?

@jonahwilliams jonahwilliams added the triaged-engine Triaged by Engine team label Jul 15, 2024
@a-siva
Copy link
Contributor

a-siva commented Oct 24, 2024

While internally we have stopped depending on android_x86_jit_release prebuilts this week, we should put this issue on hold for a month or so in case we need to roll back.

It has been more than a month, do we still need to hold off on this issue ?

@a-siva a-siva mentioned this issue Oct 24, 2024
Open
4 tasks
@jiahaog
Copy link
Member

jiahaog commented Oct 26, 2024

There have been no issues reported internally since it was removed - we can remove it now.

@matanlurey matanlurey self-assigned this Nov 12, 2024
@matanlurey
Copy link
Contributor

I will help shepard this through internally so we can safely delete this.

@matanlurey matanlurey mentioned this issue Nov 13, 2024
Merged
@matanlurey matanlurey reopened this Nov 15, 2024
@matanlurey
Copy link
Contributor

Being reverted in flutter/engine#56634, will need to re-landed.

@matanlurey matanlurey added P2 Important issues not at the top of the work list and removed P3 Issues that are less important to the Flutter project labels Nov 15, 2024
@matanlurey matanlurey mentioned this issue Nov 15, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 18, 2024
@matanlurey
No longer download android-x86-jit-release. (#159011)
7438400 
Unblocks #151610.
@matanlurey
Copy link
Contributor

Was closed again!

@matanlurey
Copy link
Contributor

@a-siva Your team should be free to remove x86-JIT!

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2024
nick9822 pushed a commit to nick9822/flutter that referenced this issue Dec 18, 2024
@matanlurey
Remove android_jit_release_x86. (flutter/engine#56548)
bcfae15 
Closes flutter#151610.

While it appears unused in google3, cl/695899069 removes trace elements in the build configuration as well.

/cc @a-siva
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@matanlurey matanlurey

Labels
engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove android_jit_release_x86. matanlurey/engine
5 participants
@matanlurey @jtmcdole @jiahaog @a-siva @jonahwilliams
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy