Skip to content

Remove schedule_during_release_override: true and use two targets instead #168913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
5 tasks
matanlurey opened this issue May 15, 2025 · 2 comments
Open
5 tasks
Assignees
Labels
c: tech-debt Technical debt, code quality, testing, etc. infra: recipes Issues with flutter/recipes infra: release Release-related requests and tooling P1 High-priority issues at the top of the work list team-infra Owned by Infrastructure team triaged-infra Triaged by Infrastructure team

Comments

@matanlurey
Copy link
Contributor

In #168709 we added a workaround, schedule_during_release_override: true:

targets:
  - name: Linux docs_publish
    schedule_during_release_override: true

Unfortunately it does not completely fix every issue that was originally regressed in #162557, namely now Linux docs_publish is run twice - once on Linux flutter_release_builder, and once on post-submit tasks scheduled after the release builder.

As far as I can tell this has no negative side-effects other than being wasteful (GCS buckets should be the same, output should be the same).

To make everything simpler, both in the recipes, and not having to add code elsewhere, we should just do:

targets:
  - name: Linux docs_publish
    enabled_branches: [master]

  - name: Linux docs_publish_release
    scheduler: release

To do this:

  • Add support for scheduler: release in the is is_release_candidate: branch of release_builder.py
  • Split the target branches in master
  • Split the target branches in flutter-3.32-candidate.0
  • Split the target branches in flutter-3.33-candidate.0
  • Remove schedule_during_release_override
@matanlurey matanlurey self-assigned this May 15, 2025
@matanlurey matanlurey added team-infra Owned by Infrastructure team P1 High-priority issues at the top of the work list c: tech-debt Technical debt, code quality, testing, etc. infra: recipes Issues with flutter/recipes infra: release Release-related requests and tooling labels May 15, 2025
@jtmcdole
Copy link
Member

feature request: we switch to bazel for defining tests and some other definition for defining ci workflows...

@matanlurey
Copy link
Contributor Author

Note to self: don't attempt to start this until 3.32 is pushed to stable.

@matanlurey matanlurey added the triaged-infra Triaged by Infrastructure team label May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: tech-debt Technical debt, code quality, testing, etc. infra: recipes Issues with flutter/recipes infra: release Release-related requests and tooling P1 High-priority issues at the top of the work list team-infra Owned by Infrastructure team triaged-infra Triaged by Infrastructure team
Projects
None yet
Development

No branches or pull requests

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy