Skip to content

Replace golden tests in test/cupertino/nav_bar_transition_test.dart #169169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
victorsanni opened this issue May 20, 2025 · 3 comments · Fixed by #169172
Closed

Replace golden tests in test/cupertino/nav_bar_transition_test.dart #169169

victorsanni opened this issue May 20, 2025 · 3 comments · Fixed by #169172
Labels
a: tests "flutter test", flutter_test, or one of our tests f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. P1 High-priority issues at the top of the work list r: fixed Issue is closed as already fixed in a newer version team-design Owned by Design Languages team triaged-design Triaged by Design Languages team

Comments

@victorsanni
Copy link
Contributor

Golden tests are unreliable in the middle of an animation, see #169155 (comment).
@victorsanni
Copy link
Contributor Author

cc @dkwingsmt @MitchellGoodwin

@dkwingsmt
Copy link
Contributor

I understand the explanation that golden tests might have got flaky because the frame is not exact mid-animation. But doesn't that mean non-golden tests are not reliable either? @jonahwilliams

@victorsanni
Copy link
Contributor Author

I understand the explanation that golden tests might have got flaky because the frame is not exact mid-animation. But doesn't that mean non-golden tests are not reliable either? @jonahwilliams

I think this is true, but with non-goldens we can approximate where the animation values would be (moreOrLessEquals, closeTo, etc) whereas goldens just immediately fail when there is any divergence.

@victorsanni victorsanni mentioned this issue May 20, 2025
Merged
@danagbemava-nc danagbemava-nc added in triage Presently being triaged by the triage team a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository team-design Owned by Design Languages team and removed in triage Presently being triaged by the triage team labels May 21, 2025
@dkwingsmt dkwingsmt added P1 High-priority issues at the top of the work list triaged-design Triaged by Design Languages team labels May 21, 2025
github-merge-queue bot pushed a commit that referenced this issue May 22, 2025
@victorsanni
Replace goldens in test/cupertino/nav_bar_transition_test.dart (#169172)
df3d1bd 
Fixes [Replace golden tests in
test/cupertino/nav_bar_transition_test.dart](#169169)

Removed one of the clipping tests because it is already covered by the
other test. The tests become a little more brittle (now using type
checks etc), but no more flaky goldens.
@danagbemava-nc danagbemava-nc added the r: fixed Issue is closed as already fixed in a newer version label May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. P1 High-priority issues at the top of the work list r: fixed Issue is closed as already fixed in a newer version team-design Owned by Design Languages team triaged-design Triaged by Design Languages team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace goldens in test/cupertino/nav_bar_transition_test.dart victorsanni/flutter
3 participants
@dkwingsmt @victorsanni @danagbemava-nc
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy