Skip to content

Backfiller misses soon-to-be-beta (but not yet) branches #169234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matanlurey opened this issue May 21, 2025 · 0 comments · Fixed by flutter/cocoon#4721
Closed

Backfiller misses soon-to-be-beta (but not yet) branches #169234

matanlurey opened this issue May 21, 2025 · 0 comments · Fixed by flutter/cocoon#4721
Assignees
Labels
infra: cocoon Related to the dashboard or cocoon server P2 Important issues not at the top of the work list team-infra Owned by Infrastructure team

Comments

@matanlurey
Copy link
Contributor

I was surprised to see that the (candidate) branch flutter-3.33.0-candidate.0 was left in a "Waiting for backfill" state in 678de86.

The cause is because the back-filler is subtly hard-coded to run on:

  • the default (main or master) branch for supported repositories
  • the candidate branch_es_ (flutter-X.XX-candidate.X) that are currently live on the respective stable or beta branches in flutter/flutter
  • a hard-coded exception for flutter/flutter/ios-experimental

Unfortunately that means that new, but not yet published, candidate branches are missed.

For flutter/flutter, the only repository where new branches are supported, we could (1) consider backfilling any branch that has had a commit as a result of a merged PR in the past {DURATION}, say the last 7 days. The other option (2) is a semi-manual trigger, i.e. adding branches that request a Run all tasks to a TLLd "watch this branch for the next N days".

If we could pull off option (1) it has less manual components and does not require more state tracking.

@matanlurey matanlurey self-assigned this May 21, 2025
@matanlurey matanlurey added team-infra Owned by Infrastructure team P1 High-priority issues at the top of the work list infra: cocoon Related to the dashboard or cocoon server labels May 21, 2025
@matanlurey matanlurey marked this as a duplicate of #169235 May 21, 2025
@matanlurey matanlurey added P2 Important issues not at the top of the work list and removed P1 High-priority issues at the top of the work list labels May 21, 2025
auto-submit bot pushed a commit to flutter/cocoon that referenced this issue May 22, 2025
…4719)

I started to work on flutter/flutter#169234 and realized the current way timestamp filtering is done with Firebase is inflexible (and personally, confusing). This adds a small-ish `TimeRange` class in `cocoon_commons` and uses it instead of `int? timestamp` to determine which commits to find.

(Even if we want a different approach than flutter/flutter#169234, this seems worth it?)
auto-submit bot pushed a commit to flutter/cocoon that referenced this issue May 22, 2025
…4721)

Closes flutter/flutter#169234.

This could be made a (dynamic) flag if needed in the future, but I don't see the need for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra: cocoon Related to the dashboard or cocoon server P2 Important issues not at the top of the work list team-infra Owned by Infrastructure team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy