-
Notifications
You must be signed in to change notification settings - Fork 28.9k
Description
Use case
FlutterDriver's scroll fires a Scroll command that triggers the _scroll
method on the handler_factory that first performs a pointer.down
, pointer.move
and then a pointer.up
. This indeed makes a lot of sense for mobile.
However, now that Flutter is also targeting desktop and web, it would be nice to have a 'normal' non-mobile scroll implemented in the FlutterDriver as a standard.
Proposal
Seeing as scrolling is the same for desktop and web, I suggest renaming the current (mobile) Scroll
Command
to MobileScroll
. Thus also renaming the method name on the factory_handler.dart
from _scroll
to _mobileScroll
.
Create a new Scroll
Command
and implement a _scroll
method on the factory_handler.dart
to perform a pointer.scroll
without the pointer.down
and pointer.up
.
I am still a bit torn on renaming the actual scroll
method on FlutterDriver
, as that is breaking.
We could just apply a scroll method on WebFlutterDriver
, but this ignores desktop.
Thoughts?
I would be happy to do the PR for this.