Skip to content

Add TextHeightBehavior argument for DefaultTextStyle.merge #153178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 15, 2024
Merged

Add TextHeightBehavior argument for DefaultTextStyle.merge #153178

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
195baeb
Add `TextHeightBehavior` argument for `DefaultTextStyle.merge`
kawaijoe Aug 9, 2024
fb6feb0
Add tests for `DefaultTextStyle.merge`
kawaijoe Aug 10, 2024
22dae0d
Remove dependence on `MaterialApp` in test
kawaijoe Aug 10, 2024
ac9bacb
Add documentation
kawaijoe Aug 10, 2024
df93e69
Update packages/flutter/lib/src/widgets/text.dart
kawaijoe Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add TextHeightBehavior argument for DefaultTextStyle.merge
  • Loading branch information
@kawaijoe
kawaijoe committed Aug 14, 2024
commit 195baeb181877d3ee9ad89efc8e5f0affcaede17
2 changes: 2 additions & 0 deletions packages/flutter/lib/src/widgets/text.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ class DefaultTextStyle extends InheritedTheme {
TextOverflow? overflow,
int? maxLines,
TextWidthBasis? textWidthBasis,
TextHeightBehavior? textHeightBehavior,
required Widget child,
}) {
return Builder(
Expand All @@ -120,6 +121,7 @@ class DefaultTextStyle extends InheritedTheme {
overflow: overflow ?? parent.overflow,
maxLines: maxLines ?? parent.maxLines,
textWidthBasis: textWidthBasis ?? parent.textWidthBasis,
textHeightBehavior: textHeightBehavior ?? parent.textHeightBehavior,
child: child,
);
},
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy