-
Notifications
You must be signed in to change notification settings - Fork 28.9k
Align nav bar bottom transition with large title animation #162097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align nav bar bottom transition with large title animation #162097
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compared to native, the fade in/fade out seems a little strong, especially when going from searchable to searchable. Other than that, LGTM.
It's tricky because in some apps there's a strong fade, in others not so much. For example, in the iOS contacts app, the fade looks quite strong: Screen.Recording.2025-02-06.at.11.23.04.AM.movI don't understand the logic behind this. |
Can we assume it's a stronger fade if one of the pages doesn't have a searchbar? |
Fair assumption. I also tried adding a segmented control as the bottom using SwiftUI's
I'm unable to exactly trace the second case, so I'm thinking we just check for the first case in this PR for now. But in the first case, is there even a fade at all? It doesn't look like it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approach LGTM, I think it's just tweaking the values. Visually the fade looks not as subtle as native, just trying to figure out why.
Slowed down, it looks like the native curve is pretty different. It looks like it is opaque for longer, and the fade comes on sharper.
Screen.Recording.2025-02-19.at.10.53.30.AM.mov
I'm finding it quite difficult to get the native values. Do you have any suggestions for the curve and other animation values? |
Makes the bottom widget sync up with the large title in hero transitions between nav bars.
Before
before.search.hero.transition.mov
After
search.hero.transition.mov
Native searchable-to-searchable:
Screen.Recording.2025-02-05.at.1.43.54.PM.mov
Flutter searchable-to-searchable:
Screen.Recording.2025-03-04.at.8.02.00.PM.mov
Fixes CupertinoSliverNavigationBar/CupertinoNavigationBar bottom is not displayed during nav bar flying hero transitions
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.