feat(FixedExtentScrollController): Add parent class properties to the constructor. #163190

StanleyCocos · 2025-02-13T06:55:31Z

This request is to add configurable parameters keepScrollOffset and debugLabel to FixedExtentScrollController.

Fixes FixedExtentScrollController.new is missing parameters present in ScrollController.new #162972

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

StanleyCocos · 2025-02-21T13:36:37Z

Could you take some time to review this request? cc @Piinks

Piinks

I am not sure we should add keepScrollOffset, I think using Scrollable.restorationId is preferred. It was added long after keepScrollOffset. I will double check on this.

packages/flutter/test/widgets/list_wheel_scroll_view_test.dart

Piinks · 2025-02-26T01:08:22Z

packages/flutter/test/widgets/list_wheel_scroll_view_test.dart

+        );
+      }
+
+      FixedExtentScrollController controller = FixedExtentScrollController(initialItem: 2);


In this test, to check that keep scroll offset is working, can you check the actual scroll offset, controller.offset? I might check the existing tests for ScrollController.keepScrollOffset for comparison.

Of course, I have updated it.

Piinks

LGTM, thank you

MitchellGoodwin

LGTM!

Piinks · 2025-03-05T21:25:46Z

I am not sure we should add keepScrollOffset, I think using Scrollable.restorationId is preferred. It was added long after keepScrollOffset. I will double check on this.

Following up on this, it is fine to pipe this through from the super class.

Piinks · 2025-03-05T21:26:36Z

Rebasing to unstick the Google testing shard here.

StanleyCocos · 2025-03-06T01:03:40Z

This Google test failed again. Can anyone help investigate? Much appreciated.

… constructor.

…s to the constructor. (flutter/flutter#163190)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Feb 13, 2025

StanleyCocos marked this pull request as ready for review February 13, 2025 10:25

justinmc requested a review from Piinks February 18, 2025 23:10

Piinks reviewed Feb 24, 2025

View reviewed changes

packages/flutter/test/widgets/list_wheel_scroll_view_test.dart Show resolved Hide resolved

StanleyCocos requested a review from Piinks February 25, 2025 03:01

Piinks reviewed Feb 26, 2025

View reviewed changes

StanleyCocos requested a review from Piinks February 26, 2025 03:48

Piinks approved these changes Mar 5, 2025

View reviewed changes

MitchellGoodwin approved these changes Mar 5, 2025

View reviewed changes

Piinks force-pushed the feature/fixed_fxtent_scroll_controller branch from aad1fbd to bc6edeb Compare March 5, 2025 21:26

MitchellGoodwin force-pushed the feature/fixed_fxtent_scroll_controller branch from d742a96 to 3d46514 Compare March 6, 2025 20:55

StanleyCocos added 5 commits March 10, 2025 13:41

feat(FixedExtentScrollController): Add parent class properties to the…

b3266b0

… constructor.

fix: format

220857a

fix: add test

affa4e4

add test

882d3bc

add test offset

2f546f5

MitchellGoodwin force-pushed the feature/fixed_fxtent_scroll_controller branch from 3d46514 to 2f546f5 Compare March 10, 2025 20:41

MitchellGoodwin added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 11, 2025

auto-submit bot added this pull request to the merge queue Mar 11, 2025

Merged via the queue into flutter:master with commit 9d2dcea Mar 11, 2025
75 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 11, 2025

engine-flutter-autoroll mentioned this pull request Mar 11, 2025

Roll Flutter from b16430b2fd57 to 9d2dcea4ab46 (23 revisions) flutter/packages#8849

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2025

9d2dcea feat(FixedExtentScrollController): Add parent class propertie…

8a8f904

…s to the constructor. (flutter/flutter#163190)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2025

9d2dcea feat(FixedExtentScrollController): Add parent class propertie…

ef427c2

…s to the constructor. (flutter/flutter#163190)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025

9d2dcea feat(FixedExtentScrollController): Add parent class propertie…

a3ae7ea

…s to the constructor. (flutter/flutter#163190)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025

9d2dcea feat(FixedExtentScrollController): Add parent class propertie…

e711854

…s to the constructor. (flutter/flutter#163190)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025

9d2dcea feat(FixedExtentScrollController): Add parent class propertie…

4909f5a

…s to the constructor. (flutter/flutter#163190)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025

9d2dcea feat(FixedExtentScrollController): Add parent class propertie…

099159b

…s to the constructor. (flutter/flutter#163190)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025

9d2dcea feat(FixedExtentScrollController): Add parent class propertie…

e8e6f9d

…s to the constructor. (flutter/flutter#163190)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2025

9d2dcea feat(FixedExtentScrollController): Add parent class propertie…

fdd284c

…s to the constructor. (flutter/flutter#163190)

StanleyCocos deleted the feature/fixed_fxtent_scroll_controller branch March 18, 2025 01:24

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 20, 2025

9d2dcea feat(FixedExtentScrollController): Add parent class propertie…

2f39373

…s to the constructor. (flutter/flutter#163190)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025

9d2dcea feat(FixedExtentScrollController): Add parent class propertie…

51da7ff

…s to the constructor. (flutter/flutter#163190)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025

9d2dcea feat(FixedExtentScrollController): Add parent class propertie…

b5e398f

…s to the constructor. (flutter/flutter#163190)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

9d2dcea feat(FixedExtentScrollController): Add parent class propertie…

17321be

…s to the constructor. (flutter/flutter#163190)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

9d2dcea feat(FixedExtentScrollController): Add parent class propertie…

6e35043

…s to the constructor. (flutter/flutter#163190)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

9d2dcea feat(FixedExtentScrollController): Add parent class propertie…

6c7f184

…s to the constructor. (flutter/flutter#163190)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

9d2dcea feat(FixedExtentScrollController): Add parent class propertie…

8106cd5

…s to the constructor. (flutter/flutter#163190)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

9d2dcea feat(FixedExtentScrollController): Add parent class propertie…

8ad304d

…s to the constructor. (flutter/flutter#163190)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

9d2dcea feat(FixedExtentScrollController): Add parent class propertie…

7444fd3

…s to the constructor. (flutter/flutter#163190)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

9d2dcea feat(FixedExtentScrollController): Add parent class propertie…

c67a0a9

…s to the constructor. (flutter/flutter#163190)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

9d2dcea feat(FixedExtentScrollController): Add parent class propertie…

87f928c

…s to the constructor. (flutter/flutter#163190)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

9d2dcea feat(FixedExtentScrollController): Add parent class propertie…

5f30e11

…s to the constructor. (flutter/flutter#163190)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

9d2dcea feat(FixedExtentScrollController): Add parent class propertie…

60e13c3

…s to the constructor. (flutter/flutter#163190)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

9d2dcea feat(FixedExtentScrollController): Add parent class propertie…

4843be8

…s to the constructor. (flutter/flutter#163190)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

9d2dcea feat(FixedExtentScrollController): Add parent class propertie…

9042c73

…s to the constructor. (flutter/flutter#163190)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

9d2dcea feat(FixedExtentScrollController): Add parent class propertie…

e8bc50f

…s to the constructor. (flutter/flutter#163190)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

9d2dcea feat(FixedExtentScrollController): Add parent class propertie…

fea5df6

…s to the constructor. (flutter/flutter#163190)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

9d2dcea feat(FixedExtentScrollController): Add parent class propertie…

6ca52ef

…s to the constructor. (flutter/flutter#163190)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

9d2dcea feat(FixedExtentScrollController): Add parent class propertie…

3b3b15f

…s to the constructor. (flutter/flutter#163190)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025

9d2dcea feat(FixedExtentScrollController): Add parent class propertie…

45ddf0a

…s to the constructor. (flutter/flutter#163190)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

9d2dcea feat(FixedExtentScrollController): Add parent class propertie…

2e22014

…s to the constructor. (flutter/flutter#163190)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

9d2dcea feat(FixedExtentScrollController): Add parent class propertie…

61cebfd

…s to the constructor. (flutter/flutter#163190)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

9d2dcea feat(FixedExtentScrollController): Add parent class propertie…

e9ad71e

…s to the constructor. (flutter/flutter#163190)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(FixedExtentScrollController): Add parent class properties to the constructor. #163190

feat(FixedExtentScrollController): Add parent class properties to the constructor. #163190

Uh oh!

StanleyCocos commented Feb 13, 2025 •

edited

Loading

Uh oh!

StanleyCocos commented Feb 21, 2025

Uh oh!

Piinks left a comment

Uh oh!

Uh oh!

Piinks Feb 26, 2025

Uh oh!

StanleyCocos Feb 26, 2025

Uh oh!

Piinks left a comment

Uh oh!

MitchellGoodwin left a comment

Uh oh!

Piinks commented Mar 5, 2025

Uh oh!

Piinks commented Mar 5, 2025

Uh oh!

StanleyCocos commented Mar 6, 2025

Uh oh!

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

feat(FixedExtentScrollController): Add parent class properties to the constructor. #163190

feat(FixedExtentScrollController): Add parent class properties to the constructor. #163190

Uh oh!

Conversation

StanleyCocos commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

StanleyCocos commented Feb 21, 2025

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Piinks Feb 26, 2025

Choose a reason for hiding this comment

Uh oh!

StanleyCocos Feb 26, 2025

Choose a reason for hiding this comment

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

MitchellGoodwin left a comment

Choose a reason for hiding this comment

Uh oh!

Piinks commented Mar 5, 2025

Uh oh!

Piinks commented Mar 5, 2025

Uh oh!

StanleyCocos commented Mar 6, 2025

Uh oh!

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

StanleyCocos commented Feb 13, 2025 •

edited

Loading