[Impeller] OpenGL MSAA for desktop/web devices. #163939
Conversation
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Ping @gaaclarke |
There was a problem hiding this comment.
lgtm, we have test coverage in the golden tests. Technically we are losing test coverage in the non msaa case. That's mostly a subset of the msaa code though so it's not the end of the world. (I'm saying that specifically to incriminate us if it ever does become a problem in the future haha)
| gl.BlitFramebuffer(0, // srcX0 | ||
| 0, // srcY0 | ||
| size.width, // srcX1 | ||
| size.height, // srcY1 | ||
| 0, // dstX0 | ||
| 0, // dstY0 | ||
| size.width, // dstX1 | ||
| size.height, // dstY1 | ||
| GL_COLOR_BUFFER_BIT, // mask | ||
| GL_NEAREST // filter |
| pass_data->discard_color_attachment = | ||
| pass_data->discard_color_attachment && | ||
| !context.GetCapabilities()->SupportsImplicitResolvingMSAA(); |
There was a problem hiding this comment.
I think the comment above needs to be updated.
| @@ -45,15 +45,18 @@ static bool IsDepthStencilFormat(PixelFormat format) { | |||
| } | |||
|
|
|||
| static TextureGLES::Type GetTextureTypeFromDescriptor( | |||
| const TextureDescriptor& desc) { | |||
| const TextureDescriptor& desc, | |||
| bool supports_implict_msaa) { | |||
There was a problem hiding this comment.
nit: I think sending in the Capabilities would be a better interface. It's more clear where people are getting this for and what the purpose is.
|
Golden file changes are available for triage from new commit, Click here to view. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Add support for MSAA without the render to texture extension. This allows our CI goldens to run with anti aliasing.
Fixes #158360 (again)