Skip to content

computeDryLayout access size bad #164663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 12, 2025
Merged

computeDryLayout access size bad #164663

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7490f1b
computeDryLayout should not access RenderBox.size
LongCatIsLooong Mar 5, 2025
d9baaf2
type check => null check
LongCatIsLooong Mar 5, 2025
bbc5700
analyzer
LongCatIsLooong Mar 6, 2025
3245c23
fix tests
LongCatIsLooong Mar 6, 2025
f14125d
fix tests
LongCatIsLooong Mar 6, 2025
02abe07
tests
LongCatIsLooong Mar 6, 2025
49a3bac
Merge branch 'master' into computeDryLayout-access-size-bad
LongCatIsLooong Mar 7, 2025
b9493c5
test names
LongCatIsLooong Mar 7, 2025
a590c25
Merge branch 'master' into computeDryLayout-access-size-bad
LongCatIsLooong Mar 11, 2025
d9dc733
Merge branch 'master' into computeDryLayout-access-size-bad
LongCatIsLooong Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
type check => null check
  • Loading branch information
@LongCatIsLooong
LongCatIsLooong committed Mar 5, 2025
commit d9baaf20a6fcfc515ec2830c147ab00e61e9f244
38 changes: 17 additions & 21 deletions packages/flutter/lib/src/rendering/object.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2594,7 +2594,7 @@ abstract class RenderObject with DiagnosticableTreeMixin implements HitTestTarge
void scheduleInitialLayout() {
assert(!_debugDisposed);
assert(attached);
assert(parent is! RenderObject);
assert(parent == null);
assert(!owner!._debugDoingLayout);
assert(_relayoutBoundary == null);
_relayoutBoundary = this;
Expand Down Expand Up @@ -2712,7 +2712,7 @@ abstract class RenderObject with DiagnosticableTreeMixin implements HitTestTarge
assert(!_debugDoingThisResize);
assert(!_debugDoingThisLayout);
final bool isRelayoutBoundary =
!parentUsesSize || sizedByParent || constraints.isTight || parent is! RenderObject;
!parentUsesSize || sizedByParent || constraints.isTight || parent == null;
final RenderObject relayoutBoundary = isRelayoutBoundary ? this : parent!._relayoutBoundary!;
assert(() {
_debugCanParentUseSize = parentUsesSize;
Expand Down Expand Up @@ -3077,8 +3077,8 @@ abstract class RenderObject with DiagnosticableTreeMixin implements HitTestTarge
return;
}
_needsCompositingBitsUpdate = true;
if (parent is RenderObject) {
final RenderObject parent = this.parent!;
final RenderObject? parent = this.parent;
if (parent != null) {
if (parent._needsCompositingBitsUpdate) {
return;
}
Expand All @@ -3089,9 +3089,7 @@ abstract class RenderObject with DiagnosticableTreeMixin implements HitTestTarge
}
}
// parent is fine (or there isn't one), but we are dirty
if (owner != null) {
owner!._nodesNeedingCompositingBitsUpdate.add(this);
}
owner?._nodesNeedingCompositingBitsUpdate.add(this);
}

late bool _needsCompositing; // initialized in the constructor
Expand Down Expand Up @@ -3299,7 +3297,7 @@ abstract class RenderObject with DiagnosticableTreeMixin implements HitTestTarge
assert(_layerHandle.layer != null);
assert(!_layerHandle.layer!.attached);
RenderObject? node = parent;
while (node is RenderObject) {
while (node != null) {
if (node.isRepaintBoundary) {
if (node._layerHandle.layer == null) {
// Looks like the subtree here has never been painted. Let it handle itself.
Expand All @@ -3324,7 +3322,7 @@ abstract class RenderObject with DiagnosticableTreeMixin implements HitTestTarge
void scheduleInitialPaint(ContainerLayer rootLayer) {
assert(rootLayer.attached);
assert(attached);
assert(parent is! RenderObject);
assert(parent == null);
assert(!owner!._debugDoingPaint);
assert(isRepaintBoundary);
assert(_layerHandle.layer == null);
Expand All @@ -3342,7 +3340,7 @@ abstract class RenderObject with DiagnosticableTreeMixin implements HitTestTarge
assert(!_debugDisposed);
assert(rootLayer.attached);
assert(attached);
assert(parent is! RenderObject);
assert(parent == null);
assert(!owner!._debugDoingPaint);
assert(isRepaintBoundary);
assert(_layerHandle.layer != null); // use scheduleInitialPaint the first time
Expand Down Expand Up @@ -3391,8 +3389,8 @@ abstract class RenderObject with DiagnosticableTreeMixin implements HitTestTarge
}
assert(() {
if (_needsCompositingBitsUpdate) {
if (parent is RenderObject) {
final RenderObject parent = this.parent!;
final RenderObject? parent = this.parent;
if (parent != null) {
bool visitedByParent = false;
parent.visitChildren((RenderObject child) {
if (child == this) {
Expand Down Expand Up @@ -3669,7 +3667,7 @@ abstract class RenderObject with DiagnosticableTreeMixin implements HitTestTarge
void scheduleInitialSemantics() {
assert(!_debugDisposed);
assert(attached);
assert(parent is! RenderObject);
assert(parent == null);
assert(!owner!._debugDoingSemantics);
assert(_semantics.parentDataDirty || !_semantics.built);
assert(owner!._semanticsOwner != null);
Expand Down Expand Up @@ -4005,14 +4003,12 @@ abstract class RenderObject with DiagnosticableTreeMixin implements HitTestTarge
Duration duration = Duration.zero,
Curve curve = Curves.ease,
}) {
if (parent is RenderObject) {
parent!.showOnScreen(
descendant: descendant ?? this,
rect: rect,
duration: duration,
curve: curve,
);
}
parent?.showOnScreen(
descendant: descendant ?? this,
rect: rect,
duration: duration,
curve: curve,
);
}

/// Adds a debug representation of a [RenderObject] optimized for including in
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy