Skip to content

Removes assumption that basis scalar and rounded_scalar match #165166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 17, 2025
Merged

Removes assumption that basis scalar and rounded_scalar match #165166

merged 7 commits into from
Mar 17, 2025

Conversation

gaaclarke
Copy link
Member

fixes #165130

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine repository. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Mar 14, 2025
jonahwilliams
jonahwilliams approved these changes Mar 14, 2025
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

can you walk me through this new math tomorrow?

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #165166 at sha a6416b6

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Mar 14, 2025
@gaaclarke
Copy link
Member Author

gaaclarke commented Mar 14, 2025 •
edited
Loading

Ah shoot, this fixes the problem, but regresses floating point inaccuracies. I was thinking unscaled_bias should be 1.0 bit that isn't the case. I'll come up with another solution.

@flutter-dashboard
Copy link

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #165166 at sha 57f4779

@gaaclarke
Copy link
Member Author

I'm increasing the scale in the test to make sure scaling is greater than 48x when the content scalar is 1. I was worried the bug would show up in playgrounds but not in goldens on ci without the change.

@flutter-dashboard
Copy link

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #165166 at sha f8b586e

@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 17, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Mar 17, 2025
Merged via the queue into flutter:master with commit 71a5b73 Mar 17, 2025
171 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 17, 2025
gaaclarke added a commit to gaaclarke/flutter that referenced this pull request Mar 18, 2025
@gaaclarke
Removes assumption that basis scalar and rounded_scalar match (flutte…
64ead24 
…r#165166)

fixes flutter#165130

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 20, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 20, 2025
@engine-flutter-autoroll
71a5b73 Removes assumption that basis scalar and rounded_scalar match (…
0e4759b 
…flutter/flutter#165166)
@gaaclarke gaaclarke mentioned this pull request Mar 20, 2025
Closed
@Piinks Piinks mentioned this pull request Mar 21, 2025
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
71a5b73 Removes assumption that basis scalar and rounded_scalar match (…
23c2dab 
…flutter/flutter#165166)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
71a5b73 Removes assumption that basis scalar and rounded_scalar match (…
0fa729b 
…flutter/flutter#165166)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
71a5b73 Removes assumption that basis scalar and rounded_scalar match (…
00903a0 
…flutter/flutter#165166)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
71a5b73 Removes assumption that basis scalar and rounded_scalar match (…
7edd4e7 
…flutter/flutter#165166)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
71a5b73 Removes assumption that basis scalar and rounded_scalar match (…
e03d0a2 
…flutter/flutter#165166)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
71a5b73 Removes assumption that basis scalar and rounded_scalar match (…
a81a60e 
…flutter/flutter#165166)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
71a5b73 Removes assumption that basis scalar and rounded_scalar match (…
adcd8d5 
…flutter/flutter#165166)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
71a5b73 Removes assumption that basis scalar and rounded_scalar match (…
8d37d2c 
…flutter/flutter#165166)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
71a5b73 Removes assumption that basis scalar and rounded_scalar match (…
6dc77f5 
…flutter/flutter#165166)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
71a5b73 Removes assumption that basis scalar and rounded_scalar match (…
2c9a8fe 
…flutter/flutter#165166)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
71a5b73 Removes assumption that basis scalar and rounded_scalar match (…
4c97df1 
…flutter/flutter#165166)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
71a5b73 Removes assumption that basis scalar and rounded_scalar match (…
d6d3715 
…flutter/flutter#165166)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
71a5b73 Removes assumption that basis scalar and rounded_scalar match (…
ed09c14 
…flutter/flutter#165166)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
71a5b73 Removes assumption that basis scalar and rounded_scalar match (…
82c21b7 
…flutter/flutter#165166)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
71a5b73 Removes assumption that basis scalar and rounded_scalar match (…
7926a2f 
…flutter/flutter#165166)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
71a5b73 Removes assumption that basis scalar and rounded_scalar match (…
31f49a9 
…flutter/flutter#165166)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
71a5b73 Removes assumption that basis scalar and rounded_scalar match (…
3f70bba 
…flutter/flutter#165166)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
71a5b73 Removes assumption that basis scalar and rounded_scalar match (…
6ce2e30 
…flutter/flutter#165166)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
71a5b73 Removes assumption that basis scalar and rounded_scalar match (…
739171e 
…flutter/flutter#165166)
stuartmorgan-g pushed a commit to flutter/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
Manual roll Flutter from b16430b to 1d954f4 (114 revisions) (#8922)
a1b1cf1 
Manual roll Flutter from b16430b to 1d954f4 (114 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@b16430b...1d954f4

2025-03-17 jacksongardner@google.com Revert "[skwasm] Dynamic Threading
(#164748)" (flutter/flutter#165350)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from fa669e2e6d12
to 52130e5c3b34 (4 revisions) (flutter/flutter#165348)
2025-03-17 31859944+LongCatIsLooong@users.noreply.github.com
`OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal`
rebuilds. (flutter/flutter#165331)
2025-03-17 jhy03261997@gmail.com [web][a11y]Delete
_childContainerElement (flutter/flutter#163662)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from e45207898e60
to fa669e2e6d12 (8 revisions) (flutter/flutter#165342)
2025-03-17 katelovett@google.com Add documentation for Java test
filtering to plugins test document (flutter/flutter#165314)
2025-03-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313)
2025-03-17 engine-flutter-autoroll@skia.org Roll Dart SDK from
9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310)
2025-03-17 kamil@szczek.dev feat(Tooltip): replace the height parameter
with constraints (flutter/flutter#163314)
2025-03-17 huy@nevercode.io Fix arrowHeadColor breaks differentiation
between states (flutter/flutter#165178)
2025-03-17 30870216+gaaclarke@users.noreply.github.com Removes
assumption that basis scalar and rounded_scalar match
(flutter/flutter#165166)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from 69cf4c2c5db8
to e45207898e60 (1 revision) (flutter/flutter#165300)
2025-03-17 34465683+rkishan516@users.noreply.github.com Refactor: Move
sliders value indicator shape to seperate file (flutter/flutter#162858)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from 3931c31032c7
to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288)
2025-03-17 matanlurey@users.noreply.github.com Delete
`docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258)
2025-03-16 engine-flutter-autoroll@skia.org Roll Skia from 3413a02d6fc8
to 3931c31032c7 (1 revision) (flutter/flutter#165277)
2025-03-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275)
2025-03-16 engine-flutter-autoroll@skia.org Roll Dart SDK from
067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269)
2025-03-16 engine-flutter-autoroll@skia.org Roll Skia from f124daeb564d
to 3413a02d6fc8 (1 revision) (flutter/flutter#165263)
2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from
40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262)
2025-03-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252)
2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from
f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250)
2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from
8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246)
2025-03-15 engine-flutter-autoroll@skia.org Roll Skia from 4568e766ed0a
to f124daeb564d (1 revision) (flutter/flutter#165245)
2025-03-15 47866232+chunhtai@users.noreply.github.com Revert "Prevent
explicit roles from merging (#164732)" (flutter/flutter#165222)
2025-03-15 engine-flutter-autoroll@skia.org Roll Skia from bac6e76abfc7
to 4568e766ed0a (5 revisions) (flutter/flutter#165241)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227)
2025-03-14 engine-flutter-autoroll@skia.org Roll Skia from 98b6922deecf
to bac6e76abfc7 (5 revisions) (flutter/flutter#165225)
2025-03-14 34871572+gmackall@users.noreply.github.com Point ktlint AS
docs to the `.editorconfig` that is actually used by ci, instead of
making a copy in the README (flutter/flutter#165213)
2025-03-14 katelovett@google.com Add remaining dart fixes for Color
deprecations when importing painting.dart (flutter/flutter#162609)
2025-03-14 737941+loic-sharma@users.noreply.github.com [Accessibility]
Add required semantics flags (flutter/flutter#164585)
2025-03-14 engine-flutter-autoroll@skia.org Roll Skia from f4467ff38f1f
to 98b6922deecf (5 revisions) (flutter/flutter#165215)
2025-03-14 jessiewong401@gmail.com Convert `BaseFlutterTask` From Groovy
to Kotlin (flutter/flutter#163148)
2025-03-14 31859944+LongCatIsLooong@users.noreply.github.com
`OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034)
2025-03-14 2shrestha22@gmail.com Remove redundant `useMaterial3: true`
(flutter/flutter#163376)
2025-03-14 engine-flutter-autoroll@skia.org Roll Packages from
9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197)
2025-03-14 1063596+reidbaker@users.noreply.github.com Changelog updates
from 3.29.2 (flutter/flutter#165194)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180)
2025-03-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175)
2025-03-14 jonahwilliams@google.com [Impeller] Enable mediatek on API
34+. (flutter/flutter#165156)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159)
2025-03-13 34871572+gmackall@users.noreply.github.com [FGP conversion]
Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143)
2025-03-13 47866232+chunhtai@users.noreply.github.com Prevent explicit
roles from merging (flutter/flutter#164732)
...
vashworth pushed a commit to vashworth/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll @vashworth
Manual roll Flutter from b16430b to 1d954f4 (114 revisions) (flutter#…
88d5013 
…8922)

Manual roll Flutter from b16430b to 1d954f4 (114 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@b16430b...1d954f4

2025-03-17 jacksongardner@google.com Revert "[skwasm] Dynamic Threading
(#164748)" (flutter/flutter#165350)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from fa669e2e6d12
to 52130e5c3b34 (4 revisions) (flutter/flutter#165348)
2025-03-17 31859944+LongCatIsLooong@users.noreply.github.com
`OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal`
rebuilds. (flutter/flutter#165331)
2025-03-17 jhy03261997@gmail.com [web][a11y]Delete
_childContainerElement (flutter/flutter#163662)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from e45207898e60
to fa669e2e6d12 (8 revisions) (flutter/flutter#165342)
2025-03-17 katelovett@google.com Add documentation for Java test
filtering to plugins test document (flutter/flutter#165314)
2025-03-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313)
2025-03-17 engine-flutter-autoroll@skia.org Roll Dart SDK from
9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310)
2025-03-17 kamil@szczek.dev feat(Tooltip): replace the height parameter
with constraints (flutter/flutter#163314)
2025-03-17 huy@nevercode.io Fix arrowHeadColor breaks differentiation
between states (flutter/flutter#165178)
2025-03-17 30870216+gaaclarke@users.noreply.github.com Removes
assumption that basis scalar and rounded_scalar match
(flutter/flutter#165166)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from 69cf4c2c5db8
to e45207898e60 (1 revision) (flutter/flutter#165300)
2025-03-17 34465683+rkishan516@users.noreply.github.com Refactor: Move
sliders value indicator shape to seperate file (flutter/flutter#162858)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from 3931c31032c7
to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288)
2025-03-17 matanlurey@users.noreply.github.com Delete
`docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258)
2025-03-16 engine-flutter-autoroll@skia.org Roll Skia from 3413a02d6fc8
to 3931c31032c7 (1 revision) (flutter/flutter#165277)
2025-03-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275)
2025-03-16 engine-flutter-autoroll@skia.org Roll Dart SDK from
067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269)
2025-03-16 engine-flutter-autoroll@skia.org Roll Skia from f124daeb564d
to 3413a02d6fc8 (1 revision) (flutter/flutter#165263)
2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from
40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262)
2025-03-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252)
2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from
f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250)
2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from
8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246)
2025-03-15 engine-flutter-autoroll@skia.org Roll Skia from 4568e766ed0a
to f124daeb564d (1 revision) (flutter/flutter#165245)
2025-03-15 47866232+chunhtai@users.noreply.github.com Revert "Prevent
explicit roles from merging (#164732)" (flutter/flutter#165222)
2025-03-15 engine-flutter-autoroll@skia.org Roll Skia from bac6e76abfc7
to 4568e766ed0a (5 revisions) (flutter/flutter#165241)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227)
2025-03-14 engine-flutter-autoroll@skia.org Roll Skia from 98b6922deecf
to bac6e76abfc7 (5 revisions) (flutter/flutter#165225)
2025-03-14 34871572+gmackall@users.noreply.github.com Point ktlint AS
docs to the `.editorconfig` that is actually used by ci, instead of
making a copy in the README (flutter/flutter#165213)
2025-03-14 katelovett@google.com Add remaining dart fixes for Color
deprecations when importing painting.dart (flutter/flutter#162609)
2025-03-14 737941+loic-sharma@users.noreply.github.com [Accessibility]
Add required semantics flags (flutter/flutter#164585)
2025-03-14 engine-flutter-autoroll@skia.org Roll Skia from f4467ff38f1f
to 98b6922deecf (5 revisions) (flutter/flutter#165215)
2025-03-14 jessiewong401@gmail.com Convert `BaseFlutterTask` From Groovy
to Kotlin (flutter/flutter#163148)
2025-03-14 31859944+LongCatIsLooong@users.noreply.github.com
`OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034)
2025-03-14 2shrestha22@gmail.com Remove redundant `useMaterial3: true`
(flutter/flutter#163376)
2025-03-14 engine-flutter-autoroll@skia.org Roll Packages from
9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197)
2025-03-14 1063596+reidbaker@users.noreply.github.com Changelog updates
from 3.29.2 (flutter/flutter#165194)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180)
2025-03-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175)
2025-03-14 jonahwilliams@google.com [Impeller] Enable mediatek on API
34+. (flutter/flutter#165156)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159)
2025-03-13 34871572+gmackall@users.noreply.github.com [FGP conversion]
Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143)
2025-03-13 47866232+chunhtai@users.noreply.github.com Prevent explicit
roles from merging (flutter/flutter#164732)
...
CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
@engine-flutter-autoroll
Manual roll Flutter from b16430b2fd57 to 1d954f4e96bd (114 revisions)…
b6536bc 
… (#8922)

Manual roll Flutter from b16430b2fd57 to 1d954f4e96bd (114 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@b16430b...1d954f4

2025-03-17 jacksongardner@google.com Revert "[skwasm] Dynamic Threading
(#164748)" (flutter/flutter#165350)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from fa669e2e6d12
to 52130e5c3b34 (4 revisions) (flutter/flutter#165348)
2025-03-17 31859944+LongCatIsLooong@users.noreply.github.com
`OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal`
rebuilds. (flutter/flutter#165331)
2025-03-17 jhy03261997@gmail.com [web][a11y]Delete
_childContainerElement (flutter/flutter#163662)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from e45207898e60
to fa669e2e6d12 (8 revisions) (flutter/flutter#165342)
2025-03-17 katelovett@google.com Add documentation for Java test
filtering to plugins test document (flutter/flutter#165314)
2025-03-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313)
2025-03-17 engine-flutter-autoroll@skia.org Roll Dart SDK from
9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310)
2025-03-17 kamil@szczek.dev feat(Tooltip): replace the height parameter
with constraints (flutter/flutter#163314)
2025-03-17 huy@nevercode.io Fix arrowHeadColor breaks differentiation
between states (flutter/flutter#165178)
2025-03-17 30870216+gaaclarke@users.noreply.github.com Removes
assumption that basis scalar and rounded_scalar match
(flutter/flutter#165166)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from 69cf4c2c5db8
to e45207898e60 (1 revision) (flutter/flutter#165300)
2025-03-17 34465683+rkishan516@users.noreply.github.com Refactor: Move
sliders value indicator shape to seperate file (flutter/flutter#162858)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from 3931c31032c7
to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288)
2025-03-17 matanlurey@users.noreply.github.com Delete
`docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258)
2025-03-16 engine-flutter-autoroll@skia.org Roll Skia from 3413a02d6fc8
to 3931c31032c7 (1 revision) (flutter/flutter#165277)
2025-03-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275)
2025-03-16 engine-flutter-autoroll@skia.org Roll Dart SDK from
067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269)
2025-03-16 engine-flutter-autoroll@skia.org Roll Skia from f124daeb564d
to 3413a02d6fc8 (1 revision) (flutter/flutter#165263)
2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from
40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262)
2025-03-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252)
2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from
f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250)
2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from
8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246)
2025-03-15 engine-flutter-autoroll@skia.org Roll Skia from 4568e766ed0a
to f124daeb564d (1 revision) (flutter/flutter#165245)
2025-03-15 47866232+chunhtai@users.noreply.github.com Revert "Prevent
explicit roles from merging (#164732)" (flutter/flutter#165222)
2025-03-15 engine-flutter-autoroll@skia.org Roll Skia from bac6e76abfc7
to 4568e766ed0a (5 revisions) (flutter/flutter#165241)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227)
2025-03-14 engine-flutter-autoroll@skia.org Roll Skia from 98b6922deecf
to bac6e76abfc7 (5 revisions) (flutter/flutter#165225)
2025-03-14 34871572+gmackall@users.noreply.github.com Point ktlint AS
docs to the `.editorconfig` that is actually used by ci, instead of
making a copy in the README (flutter/flutter#165213)
2025-03-14 katelovett@google.com Add remaining dart fixes for Color
deprecations when importing painting.dart (flutter/flutter#162609)
2025-03-14 737941+loic-sharma@users.noreply.github.com [Accessibility]
Add required semantics flags (flutter/flutter#164585)
2025-03-14 engine-flutter-autoroll@skia.org Roll Skia from f4467ff38f1f
to 98b6922deecf (5 revisions) (flutter/flutter#165215)
2025-03-14 jessiewong401@gmail.com Convert `BaseFlutterTask` From Groovy
to Kotlin (flutter/flutter#163148)
2025-03-14 31859944+LongCatIsLooong@users.noreply.github.com
`OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034)
2025-03-14 2shrestha22@gmail.com Remove redundant `useMaterial3: true`
(flutter/flutter#163376)
2025-03-14 engine-flutter-autoroll@skia.org Roll Packages from
bdb9c96 to d632936 (1 revision) (flutter/flutter#165197)
2025-03-14 1063596+reidbaker@users.noreply.github.com Changelog updates
from 3.29.2 (flutter/flutter#165194)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180)
2025-03-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175)
2025-03-14 jonahwilliams@google.com [Impeller] Enable mediatek on API
34+. (flutter/flutter#165156)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159)
2025-03-13 34871572+gmackall@users.noreply.github.com [FGP conversion]
Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143)
2025-03-13 47866232+chunhtai@users.noreply.github.com Prevent explicit
roles from merging (flutter/flutter#164732)
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
71a5b73 Removes assumption that basis scalar and rounded_scalar match (…
9573a06 
…flutter/flutter#165166)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
71a5b73 Removes assumption that basis scalar and rounded_scalar match (…
778a77a 
…flutter/flutter#165166)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
71a5b73 Removes assumption that basis scalar and rounded_scalar match (…
ccbe035 
…flutter/flutter#165166)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Manual roll Flutter from b16430b to 1d954f4 (114 revisions) (flutter#…
a06362c 
…8922)

Manual roll Flutter from b16430b to 1d954f4 (114 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@b16430b...1d954f4

2025-03-17 jacksongardner@google.com Revert "[skwasm] Dynamic Threading
(#164748)" (flutter/flutter#165350)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from fa669e2e6d12
to 52130e5c3b34 (4 revisions) (flutter/flutter#165348)
2025-03-17 31859944+LongCatIsLooong@users.noreply.github.com
`OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal`
rebuilds. (flutter/flutter#165331)
2025-03-17 jhy03261997@gmail.com [web][a11y]Delete
_childContainerElement (flutter/flutter#163662)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from e45207898e60
to fa669e2e6d12 (8 revisions) (flutter/flutter#165342)
2025-03-17 katelovett@google.com Add documentation for Java test
filtering to plugins test document (flutter/flutter#165314)
2025-03-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313)
2025-03-17 engine-flutter-autoroll@skia.org Roll Dart SDK from
9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310)
2025-03-17 kamil@szczek.dev feat(Tooltip): replace the height parameter
with constraints (flutter/flutter#163314)
2025-03-17 huy@nevercode.io Fix arrowHeadColor breaks differentiation
between states (flutter/flutter#165178)
2025-03-17 30870216+gaaclarke@users.noreply.github.com Removes
assumption that basis scalar and rounded_scalar match
(flutter/flutter#165166)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from 69cf4c2c5db8
to e45207898e60 (1 revision) (flutter/flutter#165300)
2025-03-17 34465683+rkishan516@users.noreply.github.com Refactor: Move
sliders value indicator shape to seperate file (flutter/flutter#162858)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from 3931c31032c7
to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288)
2025-03-17 matanlurey@users.noreply.github.com Delete
`docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258)
2025-03-16 engine-flutter-autoroll@skia.org Roll Skia from 3413a02d6fc8
to 3931c31032c7 (1 revision) (flutter/flutter#165277)
2025-03-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275)
2025-03-16 engine-flutter-autoroll@skia.org Roll Dart SDK from
067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269)
2025-03-16 engine-flutter-autoroll@skia.org Roll Skia from f124daeb564d
to 3413a02d6fc8 (1 revision) (flutter/flutter#165263)
2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from
40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262)
2025-03-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252)
2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from
f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250)
2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from
8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246)
2025-03-15 engine-flutter-autoroll@skia.org Roll Skia from 4568e766ed0a
to f124daeb564d (1 revision) (flutter/flutter#165245)
2025-03-15 47866232+chunhtai@users.noreply.github.com Revert "Prevent
explicit roles from merging (#164732)" (flutter/flutter#165222)
2025-03-15 engine-flutter-autoroll@skia.org Roll Skia from bac6e76abfc7
to 4568e766ed0a (5 revisions) (flutter/flutter#165241)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227)
2025-03-14 engine-flutter-autoroll@skia.org Roll Skia from 98b6922deecf
to bac6e76abfc7 (5 revisions) (flutter/flutter#165225)
2025-03-14 34871572+gmackall@users.noreply.github.com Point ktlint AS
docs to the `.editorconfig` that is actually used by ci, instead of
making a copy in the README (flutter/flutter#165213)
2025-03-14 katelovett@google.com Add remaining dart fixes for Color
deprecations when importing painting.dart (flutter/flutter#162609)
2025-03-14 737941+loic-sharma@users.noreply.github.com [Accessibility]
Add required semantics flags (flutter/flutter#164585)
2025-03-14 engine-flutter-autoroll@skia.org Roll Skia from f4467ff38f1f
to 98b6922deecf (5 revisions) (flutter/flutter#165215)
2025-03-14 jessiewong401@gmail.com Convert `BaseFlutterTask` From Groovy
to Kotlin (flutter/flutter#163148)
2025-03-14 31859944+LongCatIsLooong@users.noreply.github.com
`OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034)
2025-03-14 2shrestha22@gmail.com Remove redundant `useMaterial3: true`
(flutter/flutter#163376)
2025-03-14 engine-flutter-autoroll@skia.org Roll Packages from
9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197)
2025-03-14 1063596+reidbaker@users.noreply.github.com Changelog updates
from 3.29.2 (flutter/flutter#165194)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180)
2025-03-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175)
2025-03-14 jonahwilliams@google.com [Impeller] Enable mediatek on API
34+. (flutter/flutter#165156)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159)
2025-03-13 34871572+gmackall@users.noreply.github.com [FGP conversion]
Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143)
2025-03-13 47866232+chunhtai@users.noreply.github.com Prevent explicit
roles from merging (flutter/flutter#164732)
...
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Manual roll Flutter from b16430b to 1d954f4 (114 revisions) (flutter#…
19d634b 
…8922)

Manual roll Flutter from b16430b to 1d954f4 (114 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@b16430b...1d954f4

2025-03-17 jacksongardner@google.com Revert "[skwasm] Dynamic Threading
(#164748)" (flutter/flutter#165350)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from fa669e2e6d12
to 52130e5c3b34 (4 revisions) (flutter/flutter#165348)
2025-03-17 31859944+LongCatIsLooong@users.noreply.github.com
`OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal`
rebuilds. (flutter/flutter#165331)
2025-03-17 jhy03261997@gmail.com [web][a11y]Delete
_childContainerElement (flutter/flutter#163662)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from e45207898e60
to fa669e2e6d12 (8 revisions) (flutter/flutter#165342)
2025-03-17 katelovett@google.com Add documentation for Java test
filtering to plugins test document (flutter/flutter#165314)
2025-03-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313)
2025-03-17 engine-flutter-autoroll@skia.org Roll Dart SDK from
9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310)
2025-03-17 kamil@szczek.dev feat(Tooltip): replace the height parameter
with constraints (flutter/flutter#163314)
2025-03-17 huy@nevercode.io Fix arrowHeadColor breaks differentiation
between states (flutter/flutter#165178)
2025-03-17 30870216+gaaclarke@users.noreply.github.com Removes
assumption that basis scalar and rounded_scalar match
(flutter/flutter#165166)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from 69cf4c2c5db8
to e45207898e60 (1 revision) (flutter/flutter#165300)
2025-03-17 34465683+rkishan516@users.noreply.github.com Refactor: Move
sliders value indicator shape to seperate file (flutter/flutter#162858)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from 3931c31032c7
to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288)
2025-03-17 matanlurey@users.noreply.github.com Delete
`docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258)
2025-03-16 engine-flutter-autoroll@skia.org Roll Skia from 3413a02d6fc8
to 3931c31032c7 (1 revision) (flutter/flutter#165277)
2025-03-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275)
2025-03-16 engine-flutter-autoroll@skia.org Roll Dart SDK from
067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269)
2025-03-16 engine-flutter-autoroll@skia.org Roll Skia from f124daeb564d
to 3413a02d6fc8 (1 revision) (flutter/flutter#165263)
2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from
40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262)
2025-03-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252)
2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from
f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250)
2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from
8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246)
2025-03-15 engine-flutter-autoroll@skia.org Roll Skia from 4568e766ed0a
to f124daeb564d (1 revision) (flutter/flutter#165245)
2025-03-15 47866232+chunhtai@users.noreply.github.com Revert "Prevent
explicit roles from merging (#164732)" (flutter/flutter#165222)
2025-03-15 engine-flutter-autoroll@skia.org Roll Skia from bac6e76abfc7
to 4568e766ed0a (5 revisions) (flutter/flutter#165241)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227)
2025-03-14 engine-flutter-autoroll@skia.org Roll Skia from 98b6922deecf
to bac6e76abfc7 (5 revisions) (flutter/flutter#165225)
2025-03-14 34871572+gmackall@users.noreply.github.com Point ktlint AS
docs to the `.editorconfig` that is actually used by ci, instead of
making a copy in the README (flutter/flutter#165213)
2025-03-14 katelovett@google.com Add remaining dart fixes for Color
deprecations when importing painting.dart (flutter/flutter#162609)
2025-03-14 737941+loic-sharma@users.noreply.github.com [Accessibility]
Add required semantics flags (flutter/flutter#164585)
2025-03-14 engine-flutter-autoroll@skia.org Roll Skia from f4467ff38f1f
to 98b6922deecf (5 revisions) (flutter/flutter#165215)
2025-03-14 jessiewong401@gmail.com Convert `BaseFlutterTask` From Groovy
to Kotlin (flutter/flutter#163148)
2025-03-14 31859944+LongCatIsLooong@users.noreply.github.com
`OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034)
2025-03-14 2shrestha22@gmail.com Remove redundant `useMaterial3: true`
(flutter/flutter#163376)
2025-03-14 engine-flutter-autoroll@skia.org Roll Packages from
9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197)
2025-03-14 1063596+reidbaker@users.noreply.github.com Changelog updates
from 3.29.2 (flutter/flutter#165194)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180)
2025-03-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175)
2025-03-14 jonahwilliams@google.com [Impeller] Enable mediatek on API
34+. (flutter/flutter#165156)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159)
2025-03-13 34871572+gmackall@users.noreply.github.com [FGP conversion]
Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143)
2025-03-13 47866232+chunhtai@users.noreply.github.com Prevent explicit
roles from merging (flutter/flutter#164732)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

@jason-simmons jason-simmons Awaiting requested review from jason-simmons

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems e: impeller Impeller rendering backend issues and features requests engine flutter/engine repository. See also e: labels. will affect goldens Changes to golden files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icon position misplaced on Android
2 participants
@gaaclarke @jonahwilliams
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy