[Android] removes edge insets from a11y bound calculation #167136
Conversation
| @@ -1647,31 +1646,6 @@ void updateSemantics( | |||
| if (rootObject != null) { | |||
| final float[] identity = new float[16]; | |||
| Matrix.setIdentityM(identity, 0); | |||
| // In Android devices API 23 and above, the system nav bar can be placed on the left side | |||
There was a problem hiding this comment.
I have tested multiple version back to api 29 (I don't have devices earlier than this and simulator only goes back to 29 with a functional play store). it looks like this fix is no longer needed. I suspect the fix here was to workaround a bug in talkback which may be fixed in the later version.
There was a problem hiding this comment.
Why remove all this code when clearly at the time it was written we thought it was required.
This code looks like it was landed in flutter/engine#27083 which was in june 2021. That would land between android 30 and android 31.
According to this chart https://en.wikipedia.org/wiki/Android_version_history They all have the same google play services version.
Are you thinking that this code is working around a bug in google play services? If not and you think this is android api bifurcated then I would rather keep the code and gate it to 29 and above.
If you do think it is google play services can you try to run an older version and see if the behavior changes? I dont need us to bisect google play but want to have some more confidence.
There was a problem hiding this comment.
It is not the play store service version. I think it is the talkback version. the reason i need a play store is so that i can download talkback which isn't included in emulator.
There was a problem hiding this comment.
the latest talkback can be install on API level 23, and there isn't a way to detect talkback version afaik
There was a problem hiding this comment.
Source code I think is here:
https://github.com/google/talkback
Here is a mirror for the google version>
https://apkpure.com/android-accessibility-suite/com.google.android.marvin.talkback/versions
Here is a mirror for the version shipped by samsung.
https://talkback.en.uptodown.com/android/versions
There was a problem hiding this comment.
FWIW I agree we cant branch of the version of another app. Or at least I cant figure out a way.
There was a problem hiding this comment.
We cant branch on accessibility service version. My only request is that we download an old copy to see if the older versions required this code.
If it does require this code and the new version does not then lets merge this code deletion.
If the older version still does not need this code then I think we are back at guessing. Maybe we need to check older android versions.
|
autosubmit label was removed for flutter/flutter/167136, because - The status or check suite Windows framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
autosubmit label was removed for flutter/flutter/167136, because - The status or check suite Mac tool_integration_tests_4_5 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
fixes android part of #102725
After throughly tested various configurations from
arm64 API level 25 to API level 35
no cutout/Tall cutout/waterfall cutout
LAYOUT_IN_DISPLAY_CUTOUT_MODE_ALWAYS, LAYOUT_IN_DISPLAY_CUTOUT_MODE_DEFAULT, LAYOUT_IN_DISPLAY_CUTOUT_MODE_NEVER
Talkback 7 to talkback 15
none of the combinations would require additional left insets calculation.
I am not sure why we need it in the first place, but it seems the best course of action will be removing the code.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.