Skip to content

Fix late variable non-assignment when WASM is enabled #167954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 29, 2025
Merged

Fix late variable non-assignment when WASM is enabled #167954

merged 4 commits into from
Apr 29, 2025

Conversation

matanlurey
Copy link
Contributor

Closes #167887.

Appears to be a regression as of #165006. Might be worth CPing?

@matanlurey matanlurey requested review from bkonyi and srujzs April 28, 2025 19:59
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 28, 2025
@srujzs
Copy link
Contributor

srujzs commented Apr 28, 2025

Ouch, thanks for catching that. If I understand correctly, these logs occur every time the app is run with Wasm? If so, I agree we should cherry-pick this (or just the relevant resident_web_runner.dart changes if the change is too large).

@matanlurey
Copy link
Contributor Author

Ah mistaken branch point, my bad, the change is quite small. Will fix.

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 28, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 29, 2025
Merged via the queue into flutter:master with commit f7d7633 Apr 29, 2025
143 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 29, 2025
@matanlurey matanlurey added the cp: beta cherry pick this pull request to beta release candidate branch label Apr 29, 2025
flutteractionsbot pushed a commit to flutteractionsbot/flutter that referenced this pull request Apr 29, 2025
@matanlurey
Fix late variable non-assignment when WASM is enabled (flutter#167954)
9e7c11e 
Closes flutter#167887.

Appears to be a regression as of
flutter#165006. Might be worth CPing?
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
56014c1 
…utter/flutter#167954)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
6d62373 
…utter/flutter#167954)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
aa7f5b0 
…utter/flutter#167954)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
c3a688c 
…utter/flutter#167954)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
ed50150 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
83ab61d 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
c220359 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
b8a49a6 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
b7d31d3 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
13b5a56 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
d20ae85 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
631ab72 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
17254d7 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
4a9ee22 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
c4cbf67 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
f52c6c5 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
a8712be 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
266afaf 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
0e6eae7 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
48371a2 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
6190e1e 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
fc7e385 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
22805af 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
bc002f7 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
9150d4c 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
8d147b8 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
36d416c 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
af52b86 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
01065d7 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
ff2847a 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
108ea00 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
ff315ec 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
5257bb3 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
1b7c313 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
57314e8 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
d59699d 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
1134637 
…utter/flutter#167954)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
f7d7633f5 Fix late variable non-assignment when WASM is enabled (fl…
9789750 
…utter/flutter#167954)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srujzs srujzs srujzs approved these changes

@bkonyi bkonyi Awaiting requested review from bkonyi

Assignees
No one assigned
Labels
cp: beta cherry pick this pull request to beta release candidate branch tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tool_crash] LateError: (#0 LateError._throwLocalNotInitialized (dart:_internal-patch/internal_patch.dart:214:5))
2 participants
@matanlurey @srujzs
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy