[Android] add abiFilters to Flutter Gradle Plugin #168293
Open
+173
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
339f273 to
3645c87
Compare
0a18e48 to
eaae72e
Compare
9525cba to
4d80540
Compare
gmackall
approved these changes
May 19, 2025
There was a problem hiding this comment.
LGTM, great find in #153476 (comment)!
I had suspected that abifilters were not necessary for the same reason you mentioned (that the FGP only packages the 3 ABIs it works on by default), but had not considered that the inclusion of a different native library could cause an x86 variant to get included.
packages/flutter_tools/test/integration.shard/gradle_jni_packaging_test.dart
Outdated
Show resolved
Hide resolved
packages/flutter_tools/test/integration.shard/gradle_jni_packaging_test.dart
Show resolved
Hide resolved
4d80540 to
00b8ab6
Compare
00b8ab6 to
2e82307
Compare
|
Google testing seems to just not work w/ changes to the FGP, I'll override the failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #153476
More context in #153476 (comment) and #153476 (comment)
TLDR:
abiFilterscannot be added to templates (the original issue proposes that) because it will break the Gradle build if the--splits-per-abioption is provided:In this PR,
abiFiltersis added programmatically in the Flutter Gradle Plugin when thesplits-per-abioption is not provided and only for non-debuggable builds.As stated in #153476 (comment),
abiFiltersare actually useful in cases when a third-party dependency is used with thex86variant. In other cases (such as a fresh Flutter app project),abiFiltersare a bit excessive, but they do no harm.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.