Lazy skwasm paths and object arenas. #168996
Draft
+782
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
reviewed
May 16, 2025
yjbanov
reviewed
May 21, 2025
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| abstract class Collectable { |
There was a problem hiding this comment.
nit: Flutter codebase prefers American English (e.g. "color" instead of "colour"), so this should probably be "Collectible".
There was a problem hiding this comment.
Collectable is fine American English. 😄
mdebbar
reviewed
May 21, 2025
| @@ -740,7 +741,7 @@ class EnginePlatformDispatcher extends ui.PlatformDispatcher { | |||
| // order to perform golden tests in Flutter framework because on the HTML | |||
| // renderer, golden tests render to DOM and then take a browser screenshot, | |||
| // https://github.com/flutter/flutter/issues/137073. | |||
| if (shouldRender || renderer.rendererTag == 'html') { | |||
| if (shouldRender) { | |||
| @@ -234,7 +234,7 @@ class SkwasmPath extends SkwasmObjectWrapper<RawPath> implements ScenePath { | |||
| SkwasmPath.fromHandle(pathCombine(operation.index, path1.handle, path2.handle)); | |||
|
|
|||
| @override | |||
| ui.PathMetrics computeMetrics({bool forceClosed = false}) { | |||
| DisposablePathMetrics computeMetrics({bool forceClosed = false}) { | |||
There was a problem hiding this comment.
I'm curious why not be more specific here and say SkwasmPathMetrics?
| @@ -35,6 +35,7 @@ abstract class Renderer { | |||
| } | |||
| } | |||
|
|
|||
| Arena get frameArena; | |||
There was a problem hiding this comment.
The arena itself seems to be renderer-agnostic. Should we put it in EnginePlatformDispatcher instead?
Comment on lines
+364
to
+368
| LazyPath.fromLazyPath(LazyPath other) | ||
| : fillType = other.fillType, | ||
| constructors = other.constructors, | ||
| initializer = other.initializer, | ||
| _commands = List.from(other._commands); |
There was a problem hiding this comment.
If there's a way to copy a SkwasmPath (and it's cheap), would it be beneficial to also copy _cachedPath to avoid re-applying all the commands later?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.