[CP: 3.32] [Widget Inspector] Update on-device inspector button to generic unicode icon #169092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lutter#168847) Resolves flutter#168846 This is a follow-up to flutter#167677. For apps that do not import `package:cupertino_icons`, the new on-device button's icon shows up as a `[?]`. This fix: * adds an explicit dependency on `package:cupertino_icons` to the framework * imports `CupertinoIcons` into `lib/src/widgets/app.dart` *Note: For some reason, adding the import to `packages/flutter/lib/src/material/app.dart` and `packages/flutter/lib/src/cupertino/app.dart` did not resolve the issue. That's why I've added it to `lib/src/widgets/app.dart`, even though it's not actually used in that file.* **Let me know if this is acceptable!** (cc @Piinks) I'm guessing we might not want to add a dependency on `cupertino_icons` to the Framework (this might even be breaking change?) so if not, it might make sense to use a different icon for the on-device inspector. Thanks!
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
matanlurey
requested changes
May 19, 2025
matanlurey
approved these changes
May 20, 2025
matanlurey
approved these changes
May 20, 2025
673806f
into
flutter:flutter-3.32-candidate.0
143 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
#168846
Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples
This cherry pick fixes an issue where some users would see a question mark instead of the appropriate icon in the widget inspector button which toggles select-mode on/off.
Impact Description:
Users who don't have
cupertino_iconsas a dependency in their pubspec will see a question mark in one of the widget inspector buttons.Workaround:
Is there a workaround for this issue?
Yes, add
cupertino_iconspackage to user's pubspec.Risk:
What is the risk level of this cherry-pick?
Low
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
This was tested manually, there are no screenshot tests for this. However, this is only a UI change and not a behavior change.
Validation Steps:
What are the steps to validate that this fix works?
cupertino_iconsin its pubspec