[ Widget Previews ] Add support for localizations in widget previews #169229
+757
−134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a new `localizations` property to the `Preview` annotation, which takes a callback that returns a `PreviewLocalizationsData` object. This class contains the same localization properties that can be provided to `WidgetsApp` and other similar widgets. This change also refactors much of the localization resolution logic into a shared `LocalizationsResolver` class to allow for localization resolution to be done in the widget preview scaffold on a per-preview basis. Fixes #166433
bkonyi
commented
May 22, 2025
| /// Creates a collection of localization objects and callbacks for use in | ||
| /// widget previews. | ||
| const PreviewLocalizationsData({ | ||
| this.locale, |
There was a problem hiding this comment.
I'm wondering if the locale property should be a member of Preview instead as the PreviewLocalizationsData is probably going to be the same across the entire application, but users will likely want to create previews for different locales. Thoughts?
|
@Piinks, when you have a chance, can you review the additions to the framework and refactoring of localization resolution into a shared class? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new
localizationsproperty to thePreviewannotation, which takes a callback that returns aPreviewLocalizationsDataobject. This class contains the same localization properties that can be provided toWidgetsAppand other similar widgets.This change also refactors much of the localization resolution logic into a shared
LocalizationsResolverclass to allow for localization resolution to be done in the widget preview scaffold on a per-preview basis.Fixes #166433