Skip to content

Fix infinite loop in CupertinoSliverNavigationBar collapse animation by adding bounds check for target scroll position #170210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
1cff1b2
Fix infinite loop in CupertinoSliverNavigationBar collapse animation …
techouse Jun 8, 2025
5860d6d
Add bounds check for target scroll position in CupertinoSliverNavigat…
techouse Jun 8, 2025
c2528e1
Add test to prevent infinite animation loop in CupertinoSliverNavigat…
techouse Jun 8, 2025
9c1faa4
Update packages/flutter/test/cupertino/nav_bar_test.dart
techouse Jun 9, 2025
ee9cec4
Merge branch 'master' into fix/CupertinoSliverNavigationBar-collapse-…
techouse Jun 9, 2025
aea1af5
Merge branch 'master' into fix/CupertinoSliverNavigationBar-collapse-…
victorsanni Jun 9, 2025
9fd5d14
Merge branch 'master' into fix/CupertinoSliverNavigationBar-collapse-…
techouse Jun 9, 2025
3e05679
Merge branch 'master' into fix/CupertinoSliverNavigationBar-collapse-…
techouse Jun 10, 2025
c182ec0
Merge branch 'master' into fix/CupertinoSliverNavigationBar-collapse-…
techouse Jun 10, 2025
821e791
Merge branch 'master' into fix/CupertinoSliverNavigationBar-collapse-…
techouse Jun 10, 2025
6cf4444
Merge branch 'master' into fix/CupertinoSliverNavigationBar-collapse-…
techouse Jun 11, 2025
07b1cbf
Merge branch 'master' into fix/CupertinoSliverNavigationBar-collapse-…
techouse Jun 11, 2025
509a9f1
Merge branch 'master' into fix/CupertinoSliverNavigationBar-collapse-…
techouse Jun 11, 2025
eb82b3f
Merge branch 'master' into fix/CupertinoSliverNavigationBar-collapse-…
techouse Jun 11, 2025
bd37580
Refactor nav bar test for clarity and concise counter increment logic.
techouse Jun 11, 2025
38f385f
Merge branch 'master' into fix/CupertinoSliverNavigationBar-collapse-…
techouse Jun 11, 2025
0c4a2dd
Merge branch 'master' into fix/CupertinoSliverNavigationBar-collapse-…
techouse Jun 13, 2025
9888fa2
Merge branch 'master' into fix/CupertinoSliverNavigationBar-collapse-…
victorsanni Jun 13, 2025
a653271
Merge branch 'master' into fix/CupertinoSliverNavigationBar-collapse-…
techouse Jun 13, 2025
5de6ddb
Merge branch 'master' into fix/CupertinoSliverNavigationBar-collapse-…
techouse Jun 14, 2025
207487b
Merge branch 'master' into fix/CupertinoSliverNavigationBar-collapse-…
techouse Jun 16, 2025
c729407
Merge branch 'master' into fix/CupertinoSliverNavigationBar-collapse-…
techouse Jun 24, 2025
889608c
Merge branch 'master' into fix/CupertinoSliverNavigationBar-collapse-…
techouse Jun 25, 2025
35b5cc3
Merge branch 'master' into fix/CupertinoSliverNavigationBar-collapse-…
techouse Jul 1, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into fix/CupertinoSliverNavigationBar-collapse-…
…animation-infinite-loop
  • Loading branch information
techouse authored Jun 10, 2025
commit 821e791041e75212e5fe0f1616f3fc149620b6f7

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.

pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy