Skip to content

[ Tool ] Report Android x86 target devices as unsupported #170282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 25, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add awaits
  • Loading branch information
bkonyi committed Jun 11, 2025
commit 550653300b3a0ccb221415d87feedb692b2903fc
2 changes: 1 addition & 1 deletion packages/flutter_tools/lib/src/device.dart
Original file line number Diff line number Diff line change
Expand Up @@ -864,7 +864,7 @@ abstract class Device {
return <String, Object>{
'name': name,
'id': id,
'isSupported': isSupported(),
'isSupported': await isSupported(),
'targetPlatform': getNameForTargetPlatform(await targetPlatform),
'emulator': isLocalEmu,
'sdk': await sdkNameAndVersion,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -212,15 +212,15 @@ void main() {

testUsingContext(
'Apple TV is unsupported',
() {
() async {
final IOSSimulator simulator = IOSSimulator(
'x',
name: 'Apple TV',
simControl: simControl,
simulatorCategory: 'com.apple.CoreSimulator.SimRuntime.tvOS-14-5',
logger: logger,
);
expect(simulator.isSupported(), false);
expect(await simulator.isSupported(), false);
},
overrides: <Type, Generator>{
Platform: () => osx,
Expand All @@ -231,9 +231,9 @@ void main() {

testUsingContext(
'Apple Watch is unsupported',
() {
() async {
expect(
IOSSimulator(
await IOSSimulator(
'x',
name: 'Apple Watch',
simControl: simControl,
Expand All @@ -252,9 +252,9 @@ void main() {

testUsingContext(
'iPad 2 is supported',
() {
() async {
expect(
IOSSimulator(
await IOSSimulator(
'x',
name: 'iPad 2',
simControl: simControl,
Expand All @@ -273,9 +273,9 @@ void main() {

testUsingContext(
'iPad Retina is supported',
() {
() async {
expect(
IOSSimulator(
await IOSSimulator(
'x',
name: 'iPad Retina',
simControl: simControl,
Expand All @@ -294,9 +294,9 @@ void main() {

testUsingContext(
'iPhone 5 is supported',
() {
() async {
expect(
IOSSimulator(
await IOSSimulator(
'x',
name: 'iPhone 5',
simControl: simControl,
Expand All @@ -315,9 +315,9 @@ void main() {

testUsingContext(
'iPhone 5s is supported',
() {
() async {
expect(
IOSSimulator(
await IOSSimulator(
'x',
name: 'iPhone 5s',
simControl: simControl,
Expand All @@ -336,9 +336,9 @@ void main() {

testUsingContext(
'iPhone SE is supported',
() {
() async {
expect(
IOSSimulator(
await IOSSimulator(
'x',
name: 'iPhone SE',
simControl: simControl,
Expand All @@ -357,9 +357,9 @@ void main() {

testUsingContext(
'iPhone 7 Plus is supported',
() {
() async {
expect(
IOSSimulator(
await IOSSimulator(
'x',
name: 'iPhone 7 Plus',
simControl: simControl,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ void main() {
expect(await device.isLatestBuildInstalled(FakeApplicationPackage()), isTrue);
expect(await device.uninstallApp(FakeApplicationPackage()), isTrue);

expect(device.isSupported(), isTrue);
expect(await device.isSupported(), isTrue);
expect(device.getLogReader(), isA<DesktopLogReader>());

expect(await device.stopApp(FakeIOSApp()), isFalse);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ void main() {
expect(await device.isLatestBuildInstalled(FakeApplicationPackage()), isFalse);
expect(await device.uninstallApp(FakeApplicationPackage()), isTrue);

expect(device.isSupported(), isTrue);
expect(await device.isSupported(), isTrue);
});

testWithoutContext('does not accept profile, release, or jit-release builds', () async {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ void main() {
final GoogleChromeDevice chromeDevice =
(await webDevices.pollingGetDevices()).whereType<GoogleChromeDevice>().first;

expect(chromeDevice.isSupported(), true);
expect(await chromeDevice.isSupported(), true);
expect(await chromeDevice.sdkNameAndVersion, 'ABC');

// Verify caching works correctly.
Expand Down Expand Up @@ -288,7 +288,7 @@ void main() {
final GoogleChromeDevice chromeDevice =
(await webDevices.pollingGetDevices()).whereType<GoogleChromeDevice>().first;

expect(chromeDevice.isSupported(), true);
expect(await chromeDevice.isSupported(), true);
expect(await chromeDevice.sdkNameAndVersion, 'Google Chrome 74.0.0');

// Verify caching works correctly.
Expand Down Expand Up @@ -319,7 +319,7 @@ void main() {
processManager: processManager,
);

expect(edgeDevice.isSupported(), true);
expect(await edgeDevice.isSupported(), true);
expect(await edgeDevice.sdkNameAndVersion, '');

final GoogleChromeDevice chromeDevice = GoogleChromeDevice(
Expand All @@ -330,7 +330,7 @@ void main() {
platform: platform,
);

expect(chromeDevice.isSupported(), true);
expect(await chromeDevice.isSupported(), true);
expect(await chromeDevice.sdkNameAndVersion, 'unknown');
});

Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy