Skip to content

Fix: Ensure Text widget locale is included in semantics language tag #172034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

pedromassango
Copy link
Member

Fixes #162324

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Jul 11, 2025
@github-actions github-actions bot added the a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) label Jul 11, 2025
@pedromassango pedromassango marked this pull request as ready for review July 11, 2025 22:55
@pedromassango pedromassango enabled auto-merge July 11, 2025 22:55
@loic-sharma
Copy link
Member

loic-sharma commented Jul 11, 2025

@pedromassango Hey there, thanks for the wonderful contribution!

Instead of directly assigning folks to the pull request, could you cc them in a comment? This makes sure that the pull request shows up in triage meetings and helps us route it to the best reviewer. Due to vacations we will want someone else to review this PR, which we'll discuss during triage meetings :)

@yjbanov yjbanov removed request for yjbanov and chunhtai July 11, 2025 23:38
@yjbanov
Copy link
Contributor

yjbanov commented Jul 11, 2025

I unassigned the reviewers, who are not available right now, so the PR goes through the normal triage and finds an active reviewer.

@pedromassango
Copy link
Member Author

Instead of directly assigning folks to the pull request, could you cc them in a comment? This makes sure that the pull request shows up in triage meetings and helps us route it to the best reviewer. Due to vacations we will want someone else to review this PR

Sorry, will keep that in mind for the next ones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flutter Web: Identify any changes in language on a page by using the lang attribute (Accessibility)
3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy