-
Notifications
You must be signed in to change notification settings - Fork 28.9k
Improve assertion message in AlignmentDirectional.resolve
#172096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 7 commits into
flutter:master
from
SalehTZ:add-detailed-error-message-for-AlignmentDirectional.resolve
Jul 22, 2025
+35
−2
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
73372d4
feat: Improve assertion message in AlignmentDirectional.resolve
SalehTZ bffcfba
test: Verify assertion for null TextDirection in AlignmentDirectional
SalehTZ 375b4c9
Merge branch 'master' into add-detailed-error-message-for-AlignmentDi…
SalehTZ 505c1e5
test: Verify assertion for null TextDirection in `_MixedAlignment.res…
SalehTZ 0a40e67
fix: removed method which was added by mistake
SalehTZ e7e000d
replaced `$runtimeType` with`$AlignmentDirectional`
SalehTZ 7c6ca91
fix: incorrect variable was used
SalehTZ File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: Verify assertion for null TextDirection in `_MixedAlignment.res…
…olve` Adds a test case that uses `add()` method to ensure that calling `_MixedAlignment.resolve` with a null `TextDirection` throws a `FlutterError` with the expected improved message.
- Loading branch information
commit 505c1e5bcd1fa38aecf4fff8ee3d2396c105e7ed
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.