Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter]Marker drag event #1702

Merged
merged 13 commits into from
Aug 19, 2019
Merged

[google_maps_flutter]Marker drag event #1702

merged 13 commits into from
Aug 19, 2019

Conversation

duzenko
Copy link
Contributor

@duzenko duzenko commented Jun 4, 2019

Description

Flutter bridge to OnMarkerDragListener

Related Issues

flutter/flutter#28929

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@duzenko

This comment has been minimized.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jun 4, 2019
@cyanglaz cyanglaz changed the title Marker drag event [google_maps_flutter]Marker drag event Jun 6, 2019
@iskakaushik iskakaushik self-requested a review June 10, 2019 18:33
@duzenko

This comment has been minimized.

@brux88
Copy link

brux88 commented Jun 19, 2019

are there any news?

@jj-hoeksema
Copy link

It looks like all the requests are done but its still showing up as one missing. @duzenko Any idea on how to fix that?

@duzenko

This comment has been minimized.

@jj-hoeksema
Copy link

@iskakaushik this should be good to go, right?

Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. This looks good to me. @duzenko can you please update the pubspec and changelog?

@duzenko

This comment has been minimized.

@iskakaushik
Copy link
Contributor

sorry for the trouble, but could you please fix the conflicts, i will keep and eye out and make sure i merge this PR in first :-)

@duzenko

This comment has been minimized.

# Conflicts:
#	packages/google_maps_flutter/CHANGELOG.md
#	packages/google_maps_flutter/pubspec.yaml
@duzenko

This comment has been minimized.

@iskakaushik iskakaushik merged commit 1375af3 into flutter:master Aug 19, 2019
@joaquinperaza
Copy link

The callback receives the new position after drag event in the marker object?

@duzenko

This comment has been minimized.

@duzenko duzenko deleted the maps-marker-drag branch September 11, 2019 09:16
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
Add support for marker drag events.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy