Skip to content

move snap doc to core24 #12143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2025
Merged

move snap doc to core24 #12143

merged 3 commits into from
Jun 27, 2025

Conversation

soumyaDghosh
Copy link
Contributor

Description of what this PR is changing or adding, and why:

This PR upgrades the suggested base for snaps from core22 to core24 and also fixes a typo where core18 is mentioned.

Issues fixed by this PR (if any):

PRs or commits this PR depends on (if any):

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@soumyaDghosh soumyaDghosh requested review from sfshaza2, antfitch, parlough and a team as code owners June 22, 2025 19:27
Copy link

google-cla bot commented Jun 22, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@soumyaDghosh soumyaDghosh marked this pull request as draft June 22, 2025 20:32
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm. Can you confirm, @domesticmouse?

@sfshaza2
Copy link
Contributor

/gcbrun

@soumyaDghosh
Copy link
Contributor Author

Wait a minute, I am not sure we can move to core24. I cannot confirm core24 contains the flutter plugin. Let's wait a bit.

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Jun 23, 2025

Visit the preview URL for this PR (updated for commit 0fa8ff4):

https://flutter-docs-prod--pr12143-main-wzy0hsvg.web.app

@sfshaza2
Copy link
Contributor

According to AI, it does not. Though we can still update the core18 line.

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfshaza2
Copy link
Contributor

/gcbrun

@sfshaza2
Copy link
Contributor

Thanks for this PR, @soumyaDghosh! I'm landing it with the version that does support Flutter.

@sfshaza2 sfshaza2 marked this pull request as ready for review June 27, 2025 06:59
@sfshaza2 sfshaza2 merged commit 874533d into flutter:main Jun 27, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy