-
Notifications
You must be signed in to change notification settings - Fork 3.3k
move snap doc to core24 #12143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move snap doc to core24 #12143
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lgtm. Can you confirm, @domesticmouse?
/gcbrun |
Wait a minute, I am not sure we can move to |
Visit the preview URL for this PR (updated for commit 0fa8ff4): |
According to AI, it does not. Though we can still update the core18 line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/gcbrun |
Thanks for this PR, @soumyaDghosh! I'm landing it with the version that does support Flutter. |
Description of what this PR is changing or adding, and why:
This PR upgrades the suggested base for snaps from core22 to core24 and also fixes a typo where
core18
is mentioned.Issues fixed by this PR (if any):
PRs or commits this PR depends on (if any):
Presubmit checklist