Skip to content

Update fooof_mat to match FOOOF 1.0 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 28, 2020
Merged

Update fooof_mat to match FOOOF 1.0 #17

merged 6 commits into from
Apr 28, 2020

Conversation

TomDonoghue
Copy link
Member

This PR updates the naming (basically 'background' -> 'aperiodic') in the fooof_mat wrapper to match the updates in Python FOOOF for 1.0.

Merge this when Python FOOOF 1.0 is tagged & released!

voytek
voytek approved these changes Feb 26, 2019
View reviewed changes
Copy link

@voytek voytek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a pretty straightforward find-and-replace, so yeah, looks good to me.

@TomDonoghue TomDonoghue merged commit 018b618 into master Apr 28, 2020
@TomDonoghue TomDonoghue deleted the dev branch April 28, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voytek voytek voytek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomDonoghue @voytek
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy