Skip to content

chore: actually rm @types/json-stable-stringify #5075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025

Conversation

longlho
Copy link
Member

@longlho longlho commented Jul 7, 2025

TL;DR

Upgraded json-stable-stringify from v1.1.1 to v1.3.0 and removed unnecessary @types/json-stable-stringify dependency.

What changed?

  • Upgraded json-stable-stringify from v1.1.1 to v1.3.0 across all packages
  • Removed @types/json-stable-stringify dependency as it's no longer needed
  • Added null checks when using stringify function by using the nullish coalescing operator (?? '')
  • Updated the Element type import in cli-lib/index.ts to remove the unnecessary import
  • Updated various BUILD files to remove references to the removed type package

How to test?

  1. Run the build process to ensure all packages compile correctly
  2. Run tests to verify that JSON stringification still works as expected
  3. Verify that the null checks for stringify function calls prevent any potential issues

Why make this change?

The newer version of json-stable-stringify includes its own TypeScript type definitions, making the separate @types package unnecessary. This reduces dependencies and potential type conflicts. The added null checks also improve code robustness by handling edge cases where stringify might return null.

Copy link
Member Author

longlho commented Jul 7, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@longlho longlho marked this pull request as ready for review July 7, 2025 04:10
@longlho longlho added this pull request to the merge queue Jul 7, 2025
Merged via the queue into main with commit 019c729 Jul 7, 2025
2 checks passed
@longlho longlho deleted the 07-07-chore_actually_rm_types_json-stable-stringify branch July 7, 2025 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy