Skip to content

fix(gatsby-plugin-image): Ensure cache hash is unique #37087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 29, 2022
Merged

fix(gatsby-plugin-image): Ensure cache hash is unique #37087

merged 3 commits into from
Nov 29, 2022

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Nov 23, 2022 •
edited
Loading

Description

Add the filename to the object that is hashed inside murmurhash. This way the hash is unique even when the <StaticImage> props are identical.

Related Issues

Fixes #36809

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 23, 2022
@LekoArts LekoArts added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 23, 2022
@LekoArts LekoArts merged commit c98d947 into master Nov 29, 2022
@LekoArts LekoArts deleted the static-image-hashing branch November 29, 2022 07:57
@pieh pieh mentioned this pull request Feb 16, 2023
Closed
2 tasks
@nkuehn nkuehn mentioned this pull request Mar 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

Assignees
No one assigned
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[gatsby-plugin-image] StaticImage "src" refers to an image with the same filename in another directory.
2 participants
@LekoArts @pieh
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy