Skip to content

Fix broken view hierarchy retrieval for Jetpack Compose 1.8+ #4485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 17, 2025
Merged

Fix broken view hierarchy retrieval for Jetpack Compose 1.8+ #4485

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
74e9436
Fix broken view hierarchy retrieval for Jetpack Compose 1.8+
markushi Jun 11, 2025
582dac5
Update Changelog
markushi Jun 11, 2025
fcae43b
Merge branch 'main' into markushi/fix/session-replay-jetpack-composes…
markushi Jun 11, 2025
99a1461
Fix tests
markushi Jun 12, 2025
ab2f1a6
Merge branch 'main' into markushi/fix/session-replay-jetpack-composes…
markushi Jun 12, 2025
165b0b0
Merge branch 'main' into markushi/fix/session-replay-jetpack-composes…
markushi Jun 12, 2025
cb97d71
Update Changelog
markushi Jun 12, 2025
a2b5af3
Add more tests
markushi Jun 12, 2025
81429a6
Allow null semantics, but mask in case an exception gets thrown
markushi Jun 12, 2025
27c4ada
Merge branch 'main' into markushi/fix/session-replay-jetpack-composes…
markushi Jun 13, 2025
d7c8750
Address PR feedback
markushi Jun 16, 2025
9b89534
Merge branch 'main' into markushi/fix/session-replay-jetpack-composes…
markushi Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address PR feedback
  • Loading branch information
@markushi
markushi committed Jun 16, 2025
commit d7c87508569e24b93b46c2e71bb4bb8c3399dd8b
2 changes: 1 addition & 1 deletion ...d-replay/src/main/java/io/sentry/android/replay/viewhierarchy/ComposeViewHierarchyNode.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ internal object ComposeViewHierarchyNode {
parent = parent,
shouldMask = true,
isImportantForContentCapture = false, /* will be set by children */
isVisible = !node.outerCoordinator.isTransparent(),
isVisible = !node.outerCoordinator.isTransparent() && visibleRect.height() > 0 && visibleRect.width() > 0,
visibleRect = visibleRect
)
}
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy