Skip to content

deps: Add missing peer dependencies #16751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dev-packages/browser-integration-tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
"test:detect-flaky": "ts-node scripts/detectFlakyTests.ts"
},
"dependencies": {
"@babel/core": "^7.27.7",
"@babel/preset-typescript": "^7.16.7",
"@playwright/test": "~1.50.0",
"@sentry-internal/rrweb": "2.34.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ sentryTest('should add resource spans to pageload transaction', async ({ getLoca

const expectedScripts = [
'/init.bundle.js',
'/subject.bundle.js',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this (subject) is not defined for this test, apparently some changed webpack version emits or does not emit the empty file anymore, but this should be OK.

'https://sentry-test-site.example/path/to/script.js',
];
if (hasCdnBundle) {
Expand Down
11 changes: 7 additions & 4 deletions dev-packages/node-integration-tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@
"dependencies": {
"@aws-sdk/client-s3": "^3.552.0",
"@hapi/hapi": "^21.3.10",
"@nestjs/common": "11.0.16",
"@nestjs/core": "10.4.6",
"@nestjs/platform-express": "10.4.6",
"@nestjs/common": "11.1.3",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bumping & aligning to latest as that fixes some transitive dependency security issue.

"@nestjs/core": "11.1.3",
"@nestjs/platform-express": "11.1.3",
"@sentry/aws-serverless": "9.33.0",
"@sentry/core": "9.33.0",
"@sentry/node": "9.33.0",
Expand Down Expand Up @@ -74,7 +74,10 @@
"@types/amqplib": "^0.10.5",
"@types/node-cron": "^3.0.11",
"@types/node-schedule": "^2.1.7",
"globby": "11"
"file-type": "^20.4.1",
"globby": "11",
"react": "^18.3.1",
"zod": "^3.24.1"
},
"config": {
"mongodbMemoryServer": {
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@
"gauge/strip-ansi": "6.0.1",
"wide-align/string-width": "4.2.3",
"cliui/wrap-ansi": "7.0.0",
"**/sucrase": "getsentry/sucrase#es2020-polyfills"
"sucrase": "getsentry/sucrase#es2020-polyfills"
},
"version": "0.0.0",
"name": "sentry-javascript",
Expand Down
4 changes: 2 additions & 2 deletions packages/ember/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"postpack": "ember ts:clean"
},
"dependencies": {
"@babel/core": "^7.24.4",
"@babel/core": "^7.27.7",
"@embroider/macros": "^1.16.0",
"@sentry/browser": "9.33.0",
"@sentry/core": "9.33.0",
Expand Down Expand Up @@ -71,7 +71,7 @@
"ember-source": "~4.12.4",
"ember-template-lint": "~4.16.1",
"eslint-plugin-ember": "11.9.0",
"eslint-plugin-n": "16.0.1",
"eslint-plugin-n": "15.0.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

downgrading because this actually requires eslint 8

"eslint-plugin-qunit": "8.0.0",
"loader.js": "~4.7.0",
"qunit": "~2.22.0",
Expand Down
4 changes: 3 additions & 1 deletion packages/gatsby/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@
},
"devDependencies": {
"@testing-library/react": "^13.0.0",
"react": "^18.0.0"
"react": "^18.3.1",
"react-dom": "^18.3.1",
"webpack": "^5.0.0"
},
"scripts": {
"build": "run-p build:transpile build:types",
Expand Down
3 changes: 2 additions & 1 deletion packages/nestjs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@
"devDependencies": {
"@nestjs/common": "^10.0.0",
"@nestjs/core": "^10.0.0",
"reflect-metadata": "^0.2.2"
"reflect-metadata": "^0.2.2",
"rxjs": "^7.8.1"
},
"peerDependencies": {
"@nestjs/common": "^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0",
Expand Down
4 changes: 3 additions & 1 deletion packages/nextjs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@
"devDependencies": {
"@types/resolve": "1.20.3",
"eslint-plugin-react": "^7.31.11",
"next": "13.5.9"
"next": "13.5.9",
"react": "^18.3.1",
"react-dom": "^18.3.1"
},
"peerDependencies": {
"next": "^13.2.0 || ^14.0 || ^15.0.0-rc.0"
Expand Down
3 changes: 3 additions & 0 deletions packages/node/test/sdk/init.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ describe('init()', () => {
beforeEach(() => {
global.__SENTRY__ = {};

// prevent the logger from being enabled, resulting in console.log calls
vi.spyOn(logger, 'enable').mockImplementation(() => {});

mockAutoPerformanceIntegrations = vi.spyOn(auto, 'getAutoPerformanceIntegrations').mockImplementation(() => []);
});

Expand Down
4 changes: 3 additions & 1 deletion packages/nuxt/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,9 @@
},
"devDependencies": {
"@nuxt/module-builder": "^0.8.4",
"nuxt": "^3.13.2"
"nuxt": "^3.13.2",
"nuxi": "^3.25.1",
"vite": "^5.4.11"
},
"scripts": {
"build": "run-s build:types build:transpile",
Expand Down
2 changes: 1 addition & 1 deletion packages/nuxt/src/runtime/utils.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { ClientOptions, Context } from '@sentry/core';
import { captureException, getClient, getTraceMetaTags, logger } from '@sentry/core';
import type { VueOptions } from '@sentry/vue/src/types';
import type { CapturedErrorContext } from 'nitropack';
import type { CapturedErrorContext } from 'nitropack/types';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this apparently changed in a newer nitropack version 😭

import type { NuxtRenderHTMLContext } from 'nuxt/app';
import type { ComponentPublicInstance } from 'vue';

Expand Down
1 change: 1 addition & 0 deletions packages/react-router/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
"devDependencies": {
"@react-router/dev": "^7.5.2",
"@react-router/node": "^7.5.2",
"react": "^18.3.1",
"react-router": "^7.5.2",
"vite": "^6.1.0"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@
"history-4": "npm:history@4.6.0",
"history-5": "npm:history@4.9.0",
"node-fetch": "^2.6.7",
"react": "^18.0.0",
"react-dom": "^18.0.0",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"react-router-3": "npm:react-router@3.2.0",
"react-router-4": "npm:react-router@4.1.0",
"react-router-5": "npm:react-router@5.0.0",
Expand Down
2 changes: 2 additions & 0 deletions packages/remix/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@
"@remix-run/react": "^2.15.2",
"@remix-run/server-runtime": "2.15.2",
"@types/express": "^4.17.14",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"vite": "^5.4.11"
},
"peerDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions packages/remix/test/integration/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"@remix-run/react": "2.16.3",
"@remix-run/serve": "2.16.3",
"@sentry/remix": "file:../..",
"react": "^18",
"react-dom": "^18"
"react": "^18.3.1",
"react-dom": "^18.3.1"
},
"devDependencies": {
"@remix-run/dev": "2.16.3",
Expand Down
5 changes: 3 additions & 2 deletions packages/replay-internal/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,14 @@
},
"homepage": "https://docs.sentry.io/platforms/javascript/session-replay/",
"devDependencies": {
"@babel/core": "^7.17.5",
"@babel/core": "^7.27.7",
"@sentry-internal/replay-worker": "9.33.0",
"@sentry-internal/rrweb": "2.35.0",
"@sentry-internal/rrweb-snapshot": "2.35.0",
"fflate": "0.8.2",
"jest-matcher-utils": "^29.0.0",
"jsdom-worker": "^0.2.1"
"jsdom-worker": "^0.3.0",
"node-fetch": "^2.6.7"
},
"dependencies": {
"@sentry-internal/browser-utils": "9.33.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ describe('Unit | eventBuffer | EventBufferCompressionWorker', () => {
await expect(() => buffer.addEvent({ data: { o: 3 }, timestamp: BASE_TIMESTAMP, type: 3 })).rejects.toBeDefined();
});

describe('size limit', () => {
describe('size limit', { timeout: 10_000 }, () => {
it('rejects if size exceeds limit', async function () {
const buffer = createEventBuffer({
useCompression: true,
Expand Down
2 changes: 2 additions & 0 deletions packages/solid/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,11 @@
"devDependencies": {
"@solidjs/router": "^0.13.4",
"@solidjs/testing-library": "0.8.5",
"@testing-library/dom": "^7.21.4",
"@testing-library/jest-dom": "^6.4.5",
"@testing-library/user-event": "^14.5.2",
"solid-js": "^1.8.11",
"vite": "^5.4.11",
"vite-plugin-solid": "^2.11.6"
},
"scripts": {
Expand Down
5 changes: 4 additions & 1 deletion packages/solidstart/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,10 @@
"@solidjs/testing-library": "0.8.5",
"@testing-library/jest-dom": "^6.4.5",
"@testing-library/user-event": "^14.5.2",
"vite-plugin-solid": "^2.11.6"
"solid-js": "^1.8.4",
"vite-plugin-solid": "^2.11.6",
"vite": "^5.4.11",
"vinxi": "^0.3.12"
},
"scripts": {
"build": "run-p build:transpile build:types",
Expand Down
2 changes: 1 addition & 1 deletion packages/solidstart/src/config/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export type RollupConfig = {
plugins: unknown[];
};

export type SolidStartInlineConfig = Parameters<typeof defineConfig>[0];
export type SolidStartInlineConfig = NonNullable<Parameters<typeof defineConfig>[0]>;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type is now possible undefined, which leads to problems.


export type SolidStartInlineServerConfig = {
hooks?: {
Expand Down
7 changes: 4 additions & 3 deletions packages/solidstart/src/config/withSentry.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,11 @@ export function withSentry(

const server = (solidStartConfig.server || {}) as SolidStartInlineServerConfig;
const hooks = server.hooks || {};
const viteConfig = solidStartConfig.vite;
const vite =
typeof solidStartConfig.vite === 'function'
? (...args: unknown[]) => addSentryPluginToVite(solidStartConfig.vite(...args), sentryPluginOptions)
: addSentryPluginToVite(solidStartConfig.vite, sentryPluginOptions);
typeof viteConfig === 'function'
? (...args: Parameters<typeof viteConfig>) => addSentryPluginToVite(viteConfig(...args), sentryPluginOptions)
: addSentryPluginToVite(viteConfig, sentryPluginOptions);

return {
...solidStartConfig,
Expand Down
3 changes: 2 additions & 1 deletion packages/svelte/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@
"devDependencies": {
"@sveltejs/vite-plugin-svelte": "1.4.0",
"@testing-library/svelte": "^3.2.1",
"svelte": "3.49.0"
"svelte": "3.49.0",
"vite": "^3.0.0"
},
"scripts": {
"build": "run-p build:transpile build:types",
Expand Down
1 change: 1 addition & 0 deletions packages/sveltekit/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
"devDependencies": {
"@babel/types": "^7.26.3",
"@sveltejs/kit": "^2.0.2",
"@sveltejs/vite-plugin-svelte": "^3.0.0",
"svelte": "^4.2.8",
"vite": "^5.4.11"
},
Expand Down
10 changes: 5 additions & 5 deletions packages/vercel-edge/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,16 +40,16 @@
},
"dependencies": {
"@opentelemetry/api": "^1.9.0",
"@sentry/core": "9.33.0"
},
"devDependencies": {
"@edge-runtime/types": "3.0.1",
"@opentelemetry/core": "^1.30.1",
"@opentelemetry/resources": "^1.30.1",
"@opentelemetry/sdk-trace-base": "^1.30.1",
"@opentelemetry/semantic-conventions": "^1.34.0",
"@sentry/core": "9.33.0",
"@sentry/opentelemetry": "9.33.0"
},
"devDependencies": {
"@edge-runtime/types": "3.0.1",
"@opentelemetry/core": "^1.30.1"
},
"scripts": {
"build": "run-p build:transpile build:types",
"build:dev": "yarn build",
Expand Down
Loading
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy