Fix huggingface_hub CI tests.
#4619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4619 +/- ##
==========================================
+ Coverage 80.58% 80.69% +0.11%
==========================================
Files 156 156
Lines 16500 16500
Branches 2806 2806
==========================================
+ Hits 13296 13315 +19
+ Misses 2319 2297 -22
- Partials 885 888 +3 |
antonpirker
commented
Jul 24, 2025
| @@ -15,8 +15,10 @@ | |||
| def mock_client_post(client, post_mock): | |||
| # huggingface-hub==0.28.0 deprecates the `post` method | |||
| # so patch `_inner_post` instead | |||
| client.post = post_mock | |||
| client._inner_post = post_mock | |||
| if hasattr(client, "post"): | |||
There was a problem hiding this comment.
This is just a small improvement that i did on the fly. Because in huggingface-hub>=0.28.0 there is no .post attribute and it would be created in the tests.
sentrivana
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HuggingFace has changed its default model used in
InferenceClientand the new model breaks our CI. Change to use a non-existent model.