server : fix pooled embedding output #14645
Merged
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
approved these changes
Jul 12, 2025
|
I'm also not very familiar with rerank. This change looks OK, so merging. |
|
Ty. I do have to mention that while investigating this I found a difference between accessing 1) /embedding or 2) openai url v1/embeddings. 2) V1/embeddings seemed to work producing one vector. On v1 reranking seem to work also. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix pooled embedding server output issue reported in #14543. When using pooled embeddings, the response is now one vector per prompt entry. The response for unpooled embeddings is unchanged.
I'm not very familiar with reranking, so I didn't touch that path. But it seems like a similar fix could be in order there.