JS: Add support for escape
#19027
Merged
JS: Add support for escape
#19027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for handling the escape and unescape functions in test cases for tainted paths.
- Added test cases in TaintedPath.js to validate flows involving escape() and unescape()
- Updated change notes to document the new flow steps
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| javascript/ql/test/query-tests/Security/CWE-022/TaintedPath/TaintedPath.js | Added test cases using escape() and unescape() to trigger security alerts |
| javascript/ql/lib/change-notes/2025-03-14-escape.md | Documented the support added for escape() and unescape() flows |
Files not reviewed (2)
- javascript/ql/lib/semmle/javascript/security/dataflow/TaintedPathCustomizations.qll: Language not supported
- javascript/ql/test/query-tests/Security/CWE-022/TaintedPath/TaintedPath.expected: Language not supported
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
|
Could you also add You can look at |
asgerf
reviewed
Mar 17, 2025
javascript/ql/lib/semmle/javascript/security/dataflow/TaintedPathCustomizations.qll
Outdated
Show resolved
Hide resolved
…athCustomizations.qll Co-authored-by: Asger F <asgerf@github.com>
asgerf
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included
escapeandunescapefunctions as additional flow steps.