Rust: Remove unused impl type #19555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes now-unused support for treating impl blocks as types following recent method resolution changes.
- Deleted the
isImplSelfTypeParampredicate and theImplMentionclass inTypeMention.qll. - Removed the
TImplvariant and theImplTypeclass inType.qll.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rust/ql/lib/codeql/rust/internal/TypeMention.qll | Removed ImplMention class and related predicate |
| rust/ql/lib/codeql/rust/internal/Type.qll | Dropped TImpl from TType union and deleted ImplType |
Comments suppressed due to low confidence (2)
rust/ql/lib/codeql/rust/internal/TypeMention.qll:191
- Removal of the ImplMention class could affect type resolution for impl blocks. Please add or update tests to ensure no regressions in resolving self-path type parameters.
class ImplMention extends TypeMention, ImplItemNode {
rust/ql/lib/codeql/rust/internal/Type.qll:15
- The TImpl variant and ImplType class have been removed. Verify with tests that all type-resolution scenarios formerly handled by this variant are still correctly covered.
TImpl(Impl i) or
geoffw0
approved these changes
May 22, 2025
Right now it doesn't look very likely. I think maybe if in some future the shared library handles method resolution something like it could be needed. But that's highly speculative and even if it does happen it could look completely different. First DCA filed for some reason but the looks fine (no changes). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just realized that the type for
implblocks is in fact unused after the recent changes to method resolution.