-
Notifications
You must be signed in to change notification settings - Fork 1.7k
C++: Fix VariableAddress
instruction association for unnamed parameters
#19941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6689344
to
af15b15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
af15b15
to
64a6a15
Compare
64a6a15
to
7bbf9de
Compare
| ir.cpp:745:8:745:8 | VariableAddress: (unnamed parameter 0) | Variable address instruction 'VariableAddress: (unnamed parameter 0)' has no associated variable, in function '$@'. | ir.cpp:745:8:745:8 | void Base::Base(Base const&) | void Base::Base(Base const&) | | ||
| ir.cpp:1045:20:1045:57 | VariableAddress: (unnamed parameter 0) | Variable address instruction 'VariableAddress: (unnamed parameter 0)' has no associated variable, in function '$@'. | ir.cpp:1040:6:1040:11 | void Lambda(int, String const&) | void Lambda(int, String const&) | | ||
| ir.cpp:1049:29:1049:66 | VariableAddress: (unnamed parameter 0) | Variable address instruction 'VariableAddress: (unnamed parameter 0)' has no associated variable, in function '$@'. | ir.cpp:1040:6:1040:11 | void Lambda(int, String const&) | void Lambda(int, String const&) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that there's something not quite right with the AST you're generating, because this shouldn't happen.
7bbf9de
to
58b6317
Compare
VariableAddress
instruction association for unnamed parameters
( | ||
tag = OnlyInstructionTag() or | ||
tag = InitializerStoreTag() or | ||
tag = InitializerVariableAddressTag() or | ||
tag = InitializerIndirectStoreTag() | ||
) and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for not being clear enough. This is a problem on the extractor side. This should not be fixed here.
TranslatedParameterReadEffect.getInstructionVariable()
now handles all parameter-related instruction tags, not justOnlyInstructionTag()
.Took inspiration from base class
TranslatedParameter
.