Skip to content

C++: Fix VariableAddress instruction association for unnamed parameters #19941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

IdrissRio
Copy link
Contributor

@IdrissRio IdrissRio commented Jul 1, 2025

TranslatedParameterReadEffect.getInstructionVariable() now handles all parameter-related instruction tags, not just OnlyInstructionTag().

Took inspiration from base class TranslatedParameter.

@github-actions github-actions bot added the C++ label Jul 1, 2025
@IdrissRio IdrissRio added depends on internal PR This PR should only be merged in sync with an internal Semmle PR no-change-note-required This PR does not need a change note labels Jul 1, 2025
@IdrissRio IdrissRio force-pushed the idrissrio/copy-constructor branch 3 times, most recently from 6689344 to af15b15 Compare July 2, 2025 13:27
@IdrissRio IdrissRio marked this pull request as ready for review July 2, 2025 15:03
@Copilot Copilot AI review requested due to automatic review settings July 2, 2025 15:03
@IdrissRio IdrissRio requested a review from a team as a code owner July 2, 2025 15:03
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@IdrissRio IdrissRio marked this pull request as draft July 2, 2025 15:43
@IdrissRio IdrissRio force-pushed the idrissrio/copy-constructor branch from af15b15 to 64a6a15 Compare July 3, 2025 14:46
@IdrissRio IdrissRio marked this pull request as ready for review July 5, 2025 08:38
@IdrissRio IdrissRio force-pushed the idrissrio/copy-constructor branch from 64a6a15 to 7bbf9de Compare July 7, 2025 13:18
Comment on lines 32 to 34
| ir.cpp:745:8:745:8 | VariableAddress: (unnamed parameter 0) | Variable address instruction 'VariableAddress: (unnamed parameter 0)' has no associated variable, in function '$@'. | ir.cpp:745:8:745:8 | void Base::Base(Base const&) | void Base::Base(Base const&) |
| ir.cpp:1045:20:1045:57 | VariableAddress: (unnamed parameter 0) | Variable address instruction 'VariableAddress: (unnamed parameter 0)' has no associated variable, in function '$@'. | ir.cpp:1040:6:1040:11 | void Lambda(int, String const&) | void Lambda(int, String const&) |
| ir.cpp:1049:29:1049:66 | VariableAddress: (unnamed parameter 0) | Variable address instruction 'VariableAddress: (unnamed parameter 0)' has no associated variable, in function '$@'. | ir.cpp:1040:6:1040:11 | void Lambda(int, String const&) | void Lambda(int, String const&) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that there's something not quite right with the AST you're generating, because this shouldn't happen.

@IdrissRio IdrissRio force-pushed the idrissrio/copy-constructor branch from 7bbf9de to 58b6317 Compare July 14, 2025 13:47
@IdrissRio IdrissRio changed the title C++: accept new test results after extractor changes C++: Fix VariableAddress instruction association for unnamed parameters Jul 14, 2025
Comment on lines +860 to +865
(
tag = OnlyInstructionTag() or
tag = InitializerStoreTag() or
tag = InitializerVariableAddressTag() or
tag = InitializerIndirectStoreTag()
) and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for not being clear enough. This is a problem on the extractor side. This should not be fixed here.

@IdrissRio IdrissRio closed this Jul 14, 2025
@IdrissRio IdrissRio deleted the idrissrio/copy-constructor branch July 14, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy