Rust: Remove Resolvable.resolvesAsItem
#20027
Merged
+16
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2f84e1 to
800e96a
Compare
Removes one more use of extractor-based resolution.
800e96a to
655b3de
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR removes the resolvesAsItem method from the Resolvable class to eliminate exposure of extractor-based resolution in the public API. The functionality is replaced with a private predicate in the telemetry module where it's still needed.
- Removes the
resolvesAsItemmethod from theResolvableclass implementation - Adds a private
resolvesAsItempredicate to the telemetry comparison module - Updates call sites to use the new private predicate instead of the removed method
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rust/ql/src/queries/telemetry/RustAnalyzerComparison.qll | Adds private predicate and updates call sites to use it |
| rust/ql/lib/codeql/rust/elements/internal/ResolvableImpl.qll | Removes the resolvesAsItem method and marks file as generated |
| rust/ql/.gitattributes | Marks ResolvableImpl.qll as linguist-generated |
| rust/ql/.generated.list | Updates hash for the generated ResolvableImpl.qll file |
geoffw0
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes one more use of extractor-based resolution; while we still rely on it internally, we should not expose it.