Java: Add support to Compact Source Files #20116
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
05f6811 to
66b5755
Compare
6aac6ea to
246bbd4
Compare
java/downgrades/9f6026c400996c13842974b24f076a486ad1f69c/compilationUnit.ql
Fixed
Show fixed
Hide fixed
a5c64a6 to
c9885d5
Compare
56cd9e7 to
ac52a1b
Compare
41a7747 to
7e04c2b
Compare
7e04c2b to
5a80595
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Java 25 compact source files (JEP 512) by introducing two new predicates: Class.isImplicit() to identify implicitly declared classes and CompilationUnit.isCompactSourceFile() to identify compilation units containing compact source files.
- Added database schema support with new
isImplicitClasstable - Implemented library predicates for detecting compact source files and implicit classes
- Created comprehensive test suite with multiple query examples
Reviewed Changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| java/ql/lib/config/semmlecode.dbscheme | Added isImplicitClass table definition for tracking implicit classes |
| java/ql/lib/semmle/code/java/Type.qll | Added Class.isImplicit() predicate to detect implicit classes |
| java/ql/lib/semmle/code/java/CompilationUnit.qll | Added CompilationUnit.isCompactSourceFile() predicate |
| java/ql/lib/upgrades/*/semmlecode.dbscheme | Database upgrade schema adding isImplicitClass table |
| java/ql/lib/upgrades/*/old.dbscheme | Previous database schema for comparison |
| java/downgrades/*/semmlecode.dbscheme | Database downgrade schema removing isImplicitClass table |
| java/downgrades/*/old.dbscheme | Previous schema for downgrade comparison |
| java/ql/test/library-tests/compact-source-files/* | Test files demonstrating compact source file functionality |
| java/ql/lib/change-notes/2025-07-23-compact-source-files.md | Release notes documenting the new feature |
| } | ||
|
|
||
| class NotCompact { | ||
| //Test explict class |
There was a problem hiding this comment.
There is a spelling error in the comment: 'explict' should be 'explicit'.
Suggested change
| //Test explict class | |
| //Test explicit class |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to compact source files (JEP 512).
I adds 2 new predicates
Class.isImplicitandCompilationUnit.isCompactedSourceFile.See internal PR for more info.