Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update DESCRIPTION to require reactR >= 0.6.1 #402

Merged
merged 2 commits into from
Jan 20, 2025
Merged

docs: Update DESCRIPTION to require reactR >= 0.6.1 #402

merged 2 commits into from
Jan 20, 2025

Conversation

laresbernardo
Copy link
Contributor

This fixes issue rstudio/gt#1942

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.04%. Comparing base (91fb80e) to head (cb93004).
Report is 10 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #402      +/-   ##
==========================================
- Coverage   95.93%   92.04%   -3.90%     
==========================================
  Files          11       18       +7     
  Lines        1181     2337    +1156     
  Branches        0      699     +699     
==========================================
+ Hits         1133     2151    +1018     
- Misses         48      160     +112     
- Partials        0       26      +26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laresbernardo
Copy link
Contributor Author 

package_version(reactableDep$version) (`actual`) not equal to packageVersion("reactable") (`expected`).

`actual[[1]]`: 0 4 4 9000
`expected[[1]]`: 0 4 4 9001

Shouldn't I ramp up the version before merging with main? I can go back to "0.4.4.9000" if needed. Awaiting for confirmation.

glin
glin approved these changes Jan 20, 2025
View reviewed changes
Copy link
Owner

@glin glin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yeah, the test failure is because the version of the htmlwidget at https://github.com/glin/reactable/blob/main/inst/htmlwidgets/reactable.yaml should also match the package version. But it's not really important for development versions, so I might relax that test later.

@glin glin merged commit ab2c0fe into glin:main Jan 20, 2025
2 of 12 checks passed
@laresbernardo laresbernardo deleted the patch-1 branch January 21, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glin glin glin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laresbernardo @codecov-commenter @glin
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy