Add missing postgres type aliases #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a631807682
approved these changes
Apr 7, 2024
There was a problem hiding this comment.
Thank you for your contribution, can you add some tests in https://github.com/go-gorm/gorm ?
|
@a631807682 do you have an example of a similar test I can draw inspiration from? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
A bunch of Postgres-type aliases are missing in the migrator. AutoMigrate performs an
ALTER COLUMNeven though the column already has the specified data type.This PR adds the missing aliases, ensuring that the migrator doesn't execute the
ALTER COLUMNstatement, when the given column is already migrated.The complete list of aliases is in Table 8.1 in the Postgres documentation here.
User Case Description
Adding these aliases ensures that ALTER COLUMN isn't performed when invoking AutoMigrate on a table, where the columns used one of the following types: