updated the highlights.js plugin #5856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my request for a new feature.
I just ran into the issue that we want to put SAS code files (some analytics software suite https://www.sas.com/) into our gogs but that there was no working synthax hightlighting for these file types. I figured out that you are using highlights.js as a plugin for this and further figured out that the current version of highlights.js actually supports SAS.
I therefore herewith suggest to update the plugin to the current version.
While locally testing my changes I noticed that the automatic language deduction for SAS files did not always work and therefore I added some additional code that explicitly sets the language type for highlights.js based on the file exentsion of the source file.
I think that this is a nice to have for everyone, and thus the pull request.