Skip to content

markup: render SHA links without branch prefix #6350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 29, 2020

Conversation

laojianzi
Copy link
Contributor

@laojianzi laojianzi commented Sep 25, 2020

Refactoring PR #6349

Co-authored-by: Zhukov Roman zhukov.roman@gmail.com

@unknwon unknwon changed the title Refactor pull #6349 markup: render SHA links without branch prefix Sep 27, 2020
Copy link
Member

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please see inline comments.

@unknwon unknwon added status: needs followup Need some extra work status: reviewed It has been reviewed by maintainers labels Sep 27, 2020
@laojianzi
Copy link
Contributor Author

Thanks! Please see inline comments.

Thanks for your review!

@laojianzi laojianzi requested a review from unknwon September 27, 2020 08:02
Copy link
Member

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@unknwon unknwon removed the status: needs followup Need some extra work label Sep 29, 2020
@unknwon unknwon linked an issue Sep 29, 2020 that may be closed by this pull request
@unknwon
Copy link
Member

unknwon commented Sep 29, 2020

@laojianzi If you're interested, the next step would be refactor the repository metas to be a concrete struct, instead of a map[string]string.

@unknwon unknwon merged commit 23823e9 into gogs:main Sep 29, 2020
unknwon added a commit that referenced this pull request Oct 6, 2020
Co-authored-by: Zhukov Roman <zhukov.roman@gmail.com>
Co-authored-by: ᴜɴᴋɴᴡᴏɴ <u@gogs.io>
@unknwon unknwon mentioned this pull request Oct 7, 2020
24 tasks
@laojianzi
Copy link
Contributor Author

laojianzi commented Oct 14, 2020

@laojianzi如果您有兴趣,下一步将是将存储库meta重构为一个具体的结构,而不是一个map[string]string

@unknwon Nice, at me 👍

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: reviewed It has been reviewed by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto generated URL of commit SHA references link to wrong address
3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy