Skip to content

repo: disallow urlencoded new lines in git protocol paths #6420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 27, 2020
Merged

repo: disallow urlencoded new lines in git protocol paths #6420

merged 4 commits into from
Nov 27, 2020

Conversation

stypr
Copy link
Contributor

@stypr stypr commented Nov 16, 2020 •
edited
Loading

This will fix the issue of #6413

Related reference: go-gitea/gitea#13525

unknwon
unknwon reviewed Nov 26, 2020
View reviewed changes
@unknwon unknwon added status: needs feedback Tell me more about it status: reviewed It has been reviewed by maintainers labels Nov 26, 2020
@unknwon unknwon changed the title Disallow urlencoded new lines in git protocol paths (gogs#6413) repo: disallow urlencoded new lines in git protocol paths Nov 26, 2020
@stypr
Remove unnecessary condition (#6413)
eea3d67 
Removing the port check as requested
unknwon
unknwon approved these changes Nov 27, 2020
View reviewed changes
Copy link
Member

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@unknwon
Copy link
Member

unknwon commented Nov 27, 2020

Ah, one last thing, would you mind adding a CHANGELOG entry here? https://github.com/gogs/gogs/blob/main/CHANGELOG.md#fixed

@unknwon unknwon added status: needs followup Need some extra work and removed status: needs feedback Tell me more about it labels Nov 27, 2020
@stypr
Copy link
Contributor Author

stypr commented Nov 27, 2020

Does that look good?

@unknwon
Copy link
Member

unknwon commented Nov 27, 2020

Looks great 👍

@unknwon unknwon removed the status: needs followup Need some extra work label Nov 27, 2020
@unknwon unknwon merged commit cd469f7 into gogs:main Nov 27, 2020
unknwon added a commit that referenced this pull request Nov 27, 2020
@stypr @unknwon
repo: disallow urlencoded new lines in git protocol paths (#6420)
ec84506 
Co-authored-by: ᴜɴᴋɴᴡᴏɴ <u@gogs.io>
@unknwon unknwon mentioned this pull request Jan 17, 2022
Closed
30 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@unknwon unknwon unknwon approved these changes

Assignees
No one assigned
Labels
status: reviewed It has been reviewed by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stypr @unknwon
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy