Skip to content

Add X-Hub-Signature header to webhook deliveries #6576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add X-Hub-Signature header to webhook deliveries #6576

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4db58a0
Add X-Hub-Signature header to webhook deliveries
oatakan Jun 8, 2021
ae6cb4f
use tab to fix lint issue
oatakan Jun 9, 2021
e636f65
apply gofmt to fix lint
oatakan Jun 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add X-Hub-Signature header to webhook deliveries
  • Loading branch information
@oatakan
oatakan committed Jun 8, 2021
commit 4db58a03c50ec505307ef4367e720e7199ab1dc9
33 changes: 24 additions & 9 deletions internal/db/webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ package db

import (
"crypto/hmac"
"crypto/sha1"
"crypto/sha256"
"crypto/tls"
"encoding/hex"
Expand Down Expand Up @@ -437,6 +438,7 @@ type HookTask struct {
Type HookTaskType
URL string `xorm:"TEXT"`
Signature string `xorm:"TEXT"`
SignatureGithub string `xorm:"TEXT"`
api.Payloader `xorm:"-" json:"-"`
PayloadContent string `xorm:"TEXT"`
ContentType HookContentType
Expand Down Expand Up @@ -633,16 +635,28 @@ func prepareHookTasks(e Engine, repo *Repository, event HookEventType, p api.Pay
signature = hex.EncodeToString(sig.Sum(nil))
}

var signaturegithub string
if len(w.Secret) > 0 {
data, err := payloader.JSONPayload()
if err != nil {
log.Error("prepareWebhooks.JSONPayload: %v", err)
}
sig := hmac.New(sha1.New, []byte(w.Secret))
_, _ = sig.Write(data)
signaturegithub = "sha1=" + hex.EncodeToString(sig.Sum(nil))
}

if err = createHookTask(e, &HookTask{
RepoID: repo.ID,
HookID: w.ID,
Type: w.HookTaskType,
URL: w.URL,
Signature: signature,
Payloader: payloader,
ContentType: w.ContentType,
EventType: event,
IsSSL: w.IsSSL,
RepoID: repo.ID,
HookID: w.ID,
Type: w.HookTaskType,
URL: w.URL,
Signature: signature,
SignatureGithub: signaturegithub,
Payloader: payloader,
ContentType: w.ContentType,
EventType: event,
IsSSL: w.IsSSL,
}); err != nil {
return fmt.Errorf("createHookTask: %v", err)
}
Expand Down Expand Up @@ -694,6 +708,7 @@ func (t *HookTask) deliver() {
req := httplib.Post(t.URL).SetTimeout(timeout, timeout).
Header("X-Github-Delivery", t.UUID).
Header("X-Github-Event", string(t.EventType)).
Header("X-Hub-Signature", t.SignatureGithub).
Header("X-Gogs-Delivery", t.UUID).
Header("X-Gogs-Signature", t.Signature).
Header("X-Gogs-Event", string(t.EventType)).
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy