Skip to content

markup: use default link formation when no format in metas #6723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2022

Conversation

unknwon
Copy link
Member

@unknwon unknwon commented Jan 13, 2022

Describe the pull request

We should render issue links using default link formation when metas["format"] is not present.

Link to the issue: #6506

Checklist

  • I agree to follow the Code of Conduct by submitting this pull request.
  • I have read and acknowledge the Contributing guide.
  • I have added test cases to cover the new code.

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #6723 (3102962) into main (5f250de) will not change coverage.
The diff coverage is 100.00%.

@@          Coverage Diff          @@
##            main   #6723   +/-   ##
=====================================
  Coverage   8.79%   8.79%           
=====================================
  Files         97      97           
  Lines      13208   13208           
=====================================
  Hits        1161    1161           
  Misses     11885   11885           
  Partials     162     162           

@unknwon unknwon merged commit 5e43fa9 into main Jan 13, 2022
@unknwon unknwon deleted the jc/fix-smart-links branch January 13, 2022 02:13
unknwon added a commit that referenced this pull request Jan 13, 2022
@unknwon unknwon mentioned this pull request Jan 17, 2022
30 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smart links to other issues and PRs are not generated anymore (>= 0.12)
1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy