Skip to content

http: fix non-sense NotFound call #7003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2022
Merged

http: fix non-sense NotFound call #7003

merged 3 commits into from
Jun 4, 2022

Conversation

unknwon
Copy link
Member

@unknwon unknwon commented Jun 3, 2022

Describe the pull request

The meaning of NotFound method has been changed since 07818d5, which doesn't response anything to the client but a utility method from the router.

Link to the issue: fixes #6963

Checklist

  • I agree to follow the Code of Conduct by submitting this pull request.
  • I have read and acknowledge the Contributing guide.
  • I have added test cases to cover the new code.

@unknwon unknwon requested a review from a team June 3, 2022 15:31
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #7003 (7e6419a) into main (09ddb87) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #7003      +/-   ##
========================================
+ Coverage   8.91%   8.93%   +0.01%     
========================================
  Files         99      99              
  Lines      13280   13280              
========================================
+ Hits        1184    1186       +2     
+ Misses     11930   11929       -1     
+ Partials     166     165       -1     

@unknwon unknwon merged commit 75e1044 into main Jun 4, 2022
@unknwon unknwon deleted the jc/http-panic branch June 4, 2022 02:44
@unknwon unknwon added this to the 0.12.9 milestone Jun 4, 2022
unknwon added a commit that referenced this pull request Jun 7, 2022
dna2github pushed a commit to dna2fork/gogs that referenced this pull request May 1, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken pull requests merge action after cherry picking
2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy