issues: sanitize DisplayName
#7009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Name instead of DisplayNameName instead of DisplayName
unknwon
reviewed
Jun 4, 2022
unknwon
requested changes
Jun 4, 2022
Name instead of DisplayNameDisplayName
unknwon
approved these changes
Jun 4, 2022
unknwon
pushed a commit
that referenced
this pull request
Jun 7, 2022
* issues: display issue poster’s `Name` instead of `DisplayName` * sanitize display name * update changelog
dna2github
pushed a commit
to dna2fork/gogs
that referenced
this pull request
May 1, 2023
* issues: display issue poster’s `Name` instead of `DisplayName` * sanitize display name * update changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
DisplayNameallows all the characters from users, which leads to an XSS vulnerability when directly displayed in the issue list.Link to the issue: https://github.com/gogs/security-issues/issues/1
Checklist